From: Jinyoung CHOI <j-young.choi@samsung.com>
To: ALIM AKHTAR <alim.akhtar@samsung.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"beanhuo@micron.com" <beanhuo@micron.com>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v5 1/6] scsi: ufs: wb: Change wb_enabled condition test
Date: Fri, 29 Jul 2022 13:52:52 +0900 [thread overview]
Message-ID: <20220729045252epcms2p7fee5c1cdca5e4bef02a833e40f80649b@epcms2p7> (raw)
In-Reply-To: <20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p8>
Changed to improve readability.
As implemented in ufshcd_wb_togle_flush(), the conditional test is
modified in the same way.
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Jinyoung Choi <j-young.choi@samsung.com>
---
drivers/ufs/core/ufshcd.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 8f11f118c30e..bbf12aa6a5ae 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -5730,10 +5730,8 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool enable)
{
int ret;
- if (!ufshcd_is_wb_allowed(hba))
- return 0;
-
- if (!(enable ^ hba->dev_info.wb_enabled))
+ if (!ufshcd_is_wb_allowed(hba) ||
+ hba->dev_info.wb_enabled == enable)
return 0;
ret = __ufshcd_wb_toggle(hba, enable, QUERY_FLAG_IDN_WB_EN);
--
2.25.1
next prev parent reply other threads:[~2022-07-29 4:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p8>
2022-07-29 4:50 ` [PATCH v5 0/6] scsi: ufs: wb: Add sysfs attribute and cleanup Jinyoung CHOI
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p7>
2022-07-29 4:52 ` Jinyoung CHOI [this message]
2022-07-29 20:16 ` [PATCH v5 1/6] scsi: ufs: wb: Change wb_enabled condition test Bart Van Assche
2022-07-31 13:01 ` Stanley Chu
2022-07-29 4:54 ` [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name Jinyoung CHOI
2022-07-29 20:22 ` Bart Van Assche
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p2>
2022-08-01 3:45 ` Jinyoung CHOI
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p1>
2022-07-29 4:56 ` [PATCH v5 4/6] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed() Jinyoung CHOI
2022-07-29 20:32 ` Bart Van Assche
2022-08-01 5:27 ` RE:(2) [PATCH v5 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute Jinyoung CHOI
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p4>
2022-07-29 4:56 ` Jinyoung CHOI
2022-07-29 20:31 ` Bart Van Assche
2022-07-29 4:57 ` [PATCH v5 5/6] scsi: ufs: wb: Modify messages Jinyoung CHOI
2022-07-29 20:34 ` Bart Van Assche
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p3>
2022-08-01 5:35 ` Jinyoung CHOI
[not found] ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p5>
2022-07-29 4:59 ` [PATCH v5 6/6] scsi: ufs: wb: Move the comment to the right position Jinyoung CHOI
2022-07-29 20:34 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220729045252epcms2p7fee5c1cdca5e4bef02a833e40f80649b@epcms2p7 \
--to=j-young.choi@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®