mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jinyoung CHOI <j-young.choi@samsung.com>
To: Bart Van Assche <bvanassche@acm.org>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"beanhuo@micron.com" <beanhuo@micron.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE:(2) [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name
Date: Mon, 01 Aug 2022 12:45:38 +0900	[thread overview]
Message-ID: <20220801034538epcms2p270ca60820681d09de109a2df504a3806@epcms2p2> (raw)
In-Reply-To: <01a30932-adae-a499-1194-57c925a3633f@acm.org>

>On 7/28/22 21:54, Jinyoung CHOI wrote:
>> -static inline void ufshcd_wb_config(struct ufs_hba *hba)
>> +static void ufshcd_wb_set_default_flags(struct ufs_hba *hba)
>
>It is not clear to me why the new name is considered an improvement? The 
>old name looks better to me. If you want to rename this function anyway, 
>how about ufshcd_configure_wb()?
>
>Thanks,
>
>Bart.

It is desirable to express it as configure because it sets several values.
I will change it.
Thank you for your opinion.

Kind Regards,
Jinyoung.

  parent reply	other threads:[~2022-08-01  3:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p8>
2022-07-29  4:50 ` [PATCH v5 0/6] scsi: ufs: wb: Add sysfs attribute and cleanup Jinyoung CHOI
     [not found]   ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p7>
2022-07-29  4:52     ` [PATCH v5 1/6] scsi: ufs: wb: Change wb_enabled condition test Jinyoung CHOI
2022-07-29 20:16       ` Bart Van Assche
2022-07-31 13:01       ` Stanley Chu
2022-07-29  4:54     ` [PATCH v5 2/6] scsi: ufs: wb: Change functions name and modify parameter name Jinyoung CHOI
2022-07-29 20:22       ` Bart Van Assche
     [not found]       ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p2>
2022-08-01  3:45         ` Jinyoung CHOI [this message]
     [not found]   ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p1>
2022-07-29  4:56     ` [PATCH v5 4/6] scsi: ufs: wb: Add ufshcd_is_wb_buf_flush_allowed() Jinyoung CHOI
2022-07-29 20:32       ` Bart Van Assche
2022-08-01  5:27     ` RE:(2) [PATCH v5 3/6] scsi: ufs: wb: Add explicit flush sysfs attribute Jinyoung CHOI
     [not found]   ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p4>
2022-07-29  4:56     ` Jinyoung CHOI
2022-07-29 20:31       ` Bart Van Assche
2022-07-29  4:57     ` [PATCH v5 5/6] scsi: ufs: wb: Modify messages Jinyoung CHOI
2022-07-29 20:34       ` Bart Van Assche
     [not found]       ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p3>
2022-08-01  5:35         ` Jinyoung CHOI
     [not found]   ` <CGME20220729045045epcms2p8caf00317889ed4da8531b7466ec6e368@epcms2p5>
2022-07-29  4:59     ` [PATCH v5 6/6] scsi: ufs: wb: Move the comment to the right position Jinyoung CHOI
2022-07-29 20:34       ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220801034538epcms2p270ca60820681d09de109a2df504a3806@epcms2p2 \
    --to=j-young.choi@samsung.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®