mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Amit Kucheria <amitk@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL
	DRIVER),
	linux-arm-kernel@lists.infradead.org (moderated list:ARM/SAMSUNG
	S3C, S5P AND EXYNOS ARM ARCHITECTURES)
Subject: [PATCH v1 07/26] thermal/drivers/exynos: Use generic thermal_zone_get_trip() function
Date: Fri,  5 Aug 2022 16:57:10 +0200	[thread overview]
Message-ID: <20220805145729.2491611-8-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20220805145729.2491611-1-daniel.lezcano@linaro.org>

The thermal framework gives the possibility to register the trip
points with the thermal zone. When that is done, no get_trip_* ops are
needed and they can be removed.

Convert ops content logic into generic trip points and register them with the
thermal zone.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/thermal/samsung/exynos_tmu.c | 41 ++++++++++------------------
 1 file changed, 15 insertions(+), 26 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 51874d0a284c..5204e343d5b0 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -260,16 +260,8 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
 {
 	struct exynos_tmu_data *data = platform_get_drvdata(pdev);
 	struct thermal_zone_device *tzd = data->tzd;
-	const struct thermal_trip * const trips =
-		of_thermal_get_trip_points(tzd);
 	unsigned int status;
-	int ret = 0, temp, hyst;
-
-	if (!trips) {
-		dev_err(&pdev->dev,
-			"Cannot get trip points from device tree!\n");
-		return -ENODEV;
-	}
+	int ret = 0, temp;
 
 	if (data->soc != SOC_ARCH_EXYNOS5433) /* FIXME */
 		ret = tzd->ops->get_crit_temp(tzd, &temp);
@@ -303,19 +295,16 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
 
 		/* Write temperature code for rising and falling threshold */
 		for (i = 0; i < ntrips; i++) {
-			/* Write temperature code for rising threshold */
-			ret = tzd->ops->get_trip_temp(tzd, i, &temp);
-			if (ret)
-				goto err;
-			temp /= MCELSIUS;
-			data->tmu_set_trip_temp(data, i, temp);
 
-			/* Write temperature code for falling threshold */
-			ret = tzd->ops->get_trip_hyst(tzd, i, &hyst);
+			struct thermal_trip trip;
+			
+			ret = thermal_zone_get_trip(tzd, i, &trip);
 			if (ret)
 				goto err;
-			hyst /= MCELSIUS;
-			data->tmu_set_trip_hyst(data, i, temp, hyst);
+
+			data->tmu_set_trip_temp(data, i, trip.temperature / MCELSIUS);
+			data->tmu_set_trip_hyst(data, i, trip.temperature / MCELSIUS,
+						trip.hysteresis / MCELSIUS);
 		}
 
 		data->tmu_clear_irqs(data);
@@ -360,21 +349,21 @@ static void exynos_tmu_control(struct platform_device *pdev, bool on)
 }
 
 static void exynos4210_tmu_set_trip_temp(struct exynos_tmu_data *data,
-					 int trip, u8 temp)
+					 int trip_id, u8 temp)
 {
-	const struct thermal_trip * const trips =
-		of_thermal_get_trip_points(data->tzd);
+	struct thermal_trip trip;
 	u8 ref, th_code;
 
-	ref = trips[0].temperature / MCELSIUS;
-
-	if (trip == 0) {
+	thermal_zone_get_trip(data->tzd, 0, &trip);
+	ref = trip.temperature / MCELSIUS;
+	
+	if (trip_id == 0) {
 		th_code = temp_to_code(data, ref);
 		writeb(th_code, data->base + EXYNOS4210_TMU_REG_THRESHOLD_TEMP);
 	}
 
 	temp -= ref;
-	writeb(temp, data->base + EXYNOS4210_TMU_REG_TRIG_LEVEL0 + trip * 4);
+	writeb(temp, data->base + EXYNOS4210_TMU_REG_TRIG_LEVEL0 + trip_id * 4);
 }
 
 /* failing thresholds are not supported on Exynos4210 */
-- 
2.25.1


  parent reply	other threads:[~2022-08-05 14:58 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05 14:57 [PATCH v1 00/26] Rework the trip points creation Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 01/26] thermal/core: encapsulate ops->get_trip_* ops into a function Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 02/26] thermal/sysfs: Do not make get_trip_hyst optional Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 03/26] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 04/26] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 05/26] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-06  1:27   ` kernel test robot
2022-08-05 14:57 ` [PATCH v1 06/26] thermal/drivers/imx: " Daniel Lezcano
2022-08-05 14:57 ` Daniel Lezcano [this message]
2022-08-05 14:57 ` [PATCH v1 08/26] thermal/drivers/rcar: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 09/26] thermal/drivers/uniphier: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 10/26] thermal/drivers/hisi: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 11/26] thermal/drivers/qcom: " Daniel Lezcano
2022-08-06  6:26   ` Amit Kucheria
2022-08-05 14:57 ` [PATCH v1 12/26] thermal/drivers/OF: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 13/26] thermal/drivers/armada: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 14/26] thermal/core/OF: Remove unused functions Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 15/26] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 16/26] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 17/26] thermal/core/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 18/26] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 19/26] thermal/core/of: Remove of_thermal_is_trip_valid() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 20/26] thermal/drivers/broadcom: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 21/26] thermal/drivers/da9062: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 22/26] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 23/26] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-08 14:56   ` Hans de Goede
2022-08-08 19:34   ` Peter Kästle
2022-08-09 21:45     ` Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 24/26] thermal/drivers/cxgb4: " Daniel Lezcano
2022-08-05 20:11   ` Jakub Kicinski
2022-08-05 21:48     ` Daniel Lezcano
2022-08-05 21:58       ` Jakub Kicinski
2022-08-05 14:57 ` [PATCH v1 25/26] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-08-09 14:50   ` srinivas pandruvada
2022-08-05 14:57 ` [PATCH v1 26/26] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-05 18:50   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805145729.2491611-8-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=amitk@kernel.org \
    --cc=bzolnier@gmail.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®