From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Amit Kucheria" <amitk@kernel.org>,
linux-renesas-soc@vger.kernel.org (open list:RENESAS R-CAR
THERMAL DRIVERS)
Subject: [PATCH v1 08/26] thermal/drivers/rcar: Use generic thermal_zone_get_trip() function
Date: Fri, 5 Aug 2022 16:57:11 +0200 [thread overview]
Message-ID: <20220805145729.2491611-9-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20220805145729.2491611-1-daniel.lezcano@linaro.org>
The thermal framework gives the possibility to register the trip
points with the thermal zone. When that is done, no get_trip_* ops are
needed and they can be removed.
Convert ops content logic into generic trip points and register them with the
thermal zone.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/rcar_thermal.c | 49 +++++-----------------------------
1 file changed, 6 insertions(+), 43 deletions(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index 4df42d70d867..003457810072 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -278,52 +278,16 @@ static int rcar_thermal_get_temp(struct thermal_zone_device *zone, int *temp)
return rcar_thermal_get_current_temp(priv, temp);
}
-static int rcar_thermal_get_trip_type(struct thermal_zone_device *zone,
- int trip, enum thermal_trip_type *type)
-{
- struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
- struct device *dev = rcar_priv_to_dev(priv);
-
- /* see rcar_thermal_get_temp() */
- switch (trip) {
- case 0: /* +90 <= temp */
- *type = THERMAL_TRIP_CRITICAL;
- break;
- default:
- dev_err(dev, "rcar driver trip error\n");
- return -EINVAL;
- }
-
- return 0;
-}
-
-static int rcar_thermal_get_trip_temp(struct thermal_zone_device *zone,
- int trip, int *temp)
-{
- struct rcar_thermal_priv *priv = rcar_zone_to_priv(zone);
- struct device *dev = rcar_priv_to_dev(priv);
-
- /* see rcar_thermal_get_temp() */
- switch (trip) {
- case 0: /* +90 <= temp */
- *temp = MCELSIUS(90);
- break;
- default:
- dev_err(dev, "rcar driver trip error\n");
- return -EINVAL;
- }
-
- return 0;
-}
-
static struct thermal_zone_device_ops rcar_thermal_zone_of_ops = {
.get_temp = rcar_thermal_get_temp,
};
static struct thermal_zone_device_ops rcar_thermal_zone_ops = {
.get_temp = rcar_thermal_get_temp,
- .get_trip_type = rcar_thermal_get_trip_type,
- .get_trip_temp = rcar_thermal_get_trip_temp,
+};
+
+static struct thermal_trip trips[] = {
+ { .type = THERMAL_TRIP_CRITICAL, .temperature = 90000 }
};
/*
@@ -531,9 +495,8 @@ static int rcar_thermal_probe(struct platform_device *pdev)
dev, i, priv,
&rcar_thermal_zone_of_ops);
} else {
- priv->zone = thermal_zone_device_register(
- "rcar_thermal",
- 1, 0, priv,
+ priv->zone = thermal_zone_device_register_with_trips(
+ "rcar_thermal", trips, ARRAY_SIZE(trips), 0, priv,
&rcar_thermal_zone_ops, NULL, 0,
idle);
--
2.25.1
next prev parent reply other threads:[~2022-08-05 14:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 14:57 [PATCH v1 00/26] Rework the trip points creation Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 01/26] thermal/core: encapsulate ops->get_trip_* ops into a function Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 02/26] thermal/sysfs: Do not make get_trip_hyst optional Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 03/26] thermal/core/governors: Use thermal_zone_get_trip() instead of ops functions Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 04/26] thermal/drivers/st: Use generic trip points Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 05/26] thermal/drivers/tegra: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-06 1:27 ` kernel test robot
2022-08-05 14:57 ` [PATCH v1 06/26] thermal/drivers/imx: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 07/26] thermal/drivers/exynos: " Daniel Lezcano
2022-08-05 14:57 ` Daniel Lezcano [this message]
2022-08-05 14:57 ` [PATCH v1 09/26] thermal/drivers/uniphier: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 10/26] thermal/drivers/hisi: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 11/26] thermal/drivers/qcom: " Daniel Lezcano
2022-08-06 6:26 ` Amit Kucheria
2022-08-05 14:57 ` [PATCH v1 12/26] thermal/drivers/OF: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 13/26] thermal/drivers/armada: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 14/26] thermal/core/OF: Remove unused functions Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 15/26] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 16/26] thermal/drivers/exynos: of_thermal_get_ntrips() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 17/26] thermal/core/of: Remove of_thermal_get_ntrips() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 18/26] thermal/drivers/exynos: Replace of_thermal_is_trip_valid() by thermal_zone_get_trip() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 19/26] thermal/core/of: Remove of_thermal_is_trip_valid() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 20/26] thermal/drivers/broadcom: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 21/26] thermal/drivers/da9062: " Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 22/26] thermal/drivers/ti: Remove unused macros ti_thermal_get_trip_value() / ti_thermal_trip_is_valid() Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 23/26] thermal/drivers/acerhdf: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-08 14:56 ` Hans de Goede
2022-08-08 19:34 ` Peter Kästle
2022-08-09 21:45 ` Daniel Lezcano
2022-08-05 14:57 ` [PATCH v1 24/26] thermal/drivers/cxgb4: " Daniel Lezcano
2022-08-05 20:11 ` Jakub Kicinski
2022-08-05 21:48 ` Daniel Lezcano
2022-08-05 21:58 ` Jakub Kicinski
2022-08-05 14:57 ` [PATCH v1 25/26] thermal/intel/int340x: Replace parameter to simplify Daniel Lezcano
2022-08-09 14:50 ` srinivas pandruvada
2022-08-05 14:57 ` [PATCH v1 26/26] thermal/drivers/intel: Use generic thermal_zone_get_trip() function Daniel Lezcano
2022-08-05 18:50 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220805145729.2491611-9-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®