mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Michael Straube <straube.linux@gmail.com>,
	Pavel Skripkin <paskripkin@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH v2 1/5] staging: r8188eu: replace a get_da call
Date: Sat,  6 Aug 2022 13:13:48 +0200	[thread overview]
Message-ID: <20220806111352.690650-2-martin@kaiser.cx> (raw)
In-Reply-To: <20220806111352.690650-1-martin@kaiser.cx>

The r8188eu driver implements an internal get_da function to read the
destination address (da) from an incoming message. Callers of this
function should be updated to use the ieee80211 framework, with the goal
of removing get_da eventually.

This patch replaces a get_da call in the OnAssocRsp function.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
 - rewrite the summary and the commit message

 drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 32d0e101d0c2..f5f718488929 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1320,6 +1320,7 @@ unsigned int OnAssocReq(struct adapter *padapter, struct recv_frame *precv_frame
 
 unsigned int OnAssocRsp(struct adapter *padapter, struct recv_frame *precv_frame)
 {
+	struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data;
 	uint i;
 	int res;
 	unsigned short	status;
@@ -1331,7 +1332,7 @@ unsigned int OnAssocRsp(struct adapter *padapter, struct recv_frame *precv_frame
 	uint pkt_len = precv_frame->len;
 
 	/* check A1 matches or not */
-	if (memcmp(myid(&padapter->eeprompriv), get_da(pframe), ETH_ALEN))
+	if (memcmp(myid(&padapter->eeprompriv), mgmt->da, ETH_ALEN))
 		return _SUCCESS;
 
 	if (!(pmlmeinfo->state & (WIFI_FW_AUTH_SUCCESS | WIFI_FW_ASSOC_STATE)))
-- 
2.30.2


  reply	other threads:[~2022-08-06 11:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-24 15:39 [PATCH 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Martin Kaiser
2022-07-24 15:39 ` [PATCH 1/5] staging: r8188eu: get da from ieee80211_mgmt Martin Kaiser
2022-07-27  6:43   ` Greg Kroah-Hartman
2022-07-28  5:25     ` Martin Kaiser
2022-07-28  6:58       ` Greg Kroah-Hartman
2022-07-24 15:39 ` [PATCH 2/5] staging: r8188eu: read status_code from struct ieee80211_mgmt Martin Kaiser
2022-07-24 15:39 ` [PATCH 3/5] staging: r8188eu: read capability info " Martin Kaiser
2022-07-24 15:39 ` [PATCH 4/5] staging: r8188eu: read aid " Martin Kaiser
2022-07-24 15:39 ` [PATCH 5/5] staging: r8188eu: use offsetof for ie start offset Martin Kaiser
2022-07-24 18:32 ` [PATCH 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Philipp Hortmann
2022-08-06 11:13 ` [PATCH v2 " Martin Kaiser
2022-08-06 11:13   ` Martin Kaiser [this message]
2022-08-06 11:13   ` [PATCH v2 2/5] staging: r8188eu: read status_code from struct ieee80211_mgmt Martin Kaiser
2022-08-06 11:13   ` [PATCH v2 3/5] staging: r8188eu: read capability info " Martin Kaiser
2022-08-06 11:13   ` [PATCH v2 4/5] staging: r8188eu: read aid " Martin Kaiser
2022-08-06 11:13   ` [PATCH v2 5/5] staging: r8188eu: simplify the calculation of ie start offset Martin Kaiser
2022-08-06 20:52   ` [PATCH v2 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Philipp Hortmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220806111352.690650-2-martin@kaiser.cx \
    --to=martin@kaiser.cx \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=paskripkin@gmail.com \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®