From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
Pavel Skripkin <paskripkin@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH v2 5/5] staging: r8188eu: simplify the calculation of ie start offset
Date: Sat, 6 Aug 2022 13:13:52 +0200 [thread overview]
Message-ID: <20220806111352.690650-6-martin@kaiser.cx> (raw)
In-Reply-To: <20220806111352.690650-1-martin@kaiser.cx>
Use offsetof to calculate the start offset of the information elements in
an association response message. This should make it easier to understand
how the offset is calculated.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
- rewrite the commit message
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 10074355b82d..6d3d5ff9a00e 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1359,7 +1359,7 @@ unsigned int OnAssocRsp(struct adapter *padapter, struct recv_frame *precv_frame
/* following are moved to join event callback function */
/* to handle HT, WMM, rate adaptive, update MAC reg */
/* for not to handle the synchronous IO in the tasklet */
- for (i = (6 + WLAN_HDR_A3_LEN); i < pkt_len;) {
+ for (i = offsetof(struct ieee80211_mgmt, u.assoc_resp.variable); i < pkt_len;) {
pIE = (struct ndis_802_11_var_ie *)(pframe + i);
switch (pIE->ElementID) {
--
2.30.2
next prev parent reply other threads:[~2022-08-06 11:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-24 15:39 [PATCH 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Martin Kaiser
2022-07-24 15:39 ` [PATCH 1/5] staging: r8188eu: get da from ieee80211_mgmt Martin Kaiser
2022-07-27 6:43 ` Greg Kroah-Hartman
2022-07-28 5:25 ` Martin Kaiser
2022-07-28 6:58 ` Greg Kroah-Hartman
2022-07-24 15:39 ` [PATCH 2/5] staging: r8188eu: read status_code from struct ieee80211_mgmt Martin Kaiser
2022-07-24 15:39 ` [PATCH 3/5] staging: r8188eu: read capability info " Martin Kaiser
2022-07-24 15:39 ` [PATCH 4/5] staging: r8188eu: read aid " Martin Kaiser
2022-07-24 15:39 ` [PATCH 5/5] staging: r8188eu: use offsetof for ie start offset Martin Kaiser
2022-07-24 18:32 ` [PATCH 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Philipp Hortmann
2022-08-06 11:13 ` [PATCH v2 " Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 1/5] staging: r8188eu: replace a get_da call Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 2/5] staging: r8188eu: read status_code from struct ieee80211_mgmt Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 3/5] staging: r8188eu: read capability info " Martin Kaiser
2022-08-06 11:13 ` [PATCH v2 4/5] staging: r8188eu: read aid " Martin Kaiser
2022-08-06 11:13 ` Martin Kaiser [this message]
2022-08-06 20:52 ` [PATCH v2 0/5] staging: r8188eu: use struct ieee80211_mgmt in OnAssocRsp Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220806111352.690650-6-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®