From: Guenter Roeck <linux@roeck-us.net>
To: sunliming <sunliming@kylinos.cn>
Cc: wim@linux-watchdog.org, arnd@arndb.de,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
kelulanainsley@gmail.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] watchdog: sa1100: make variable sa1100dog_driver static
Date: Mon, 8 Aug 2022 06:30:46 -0700 [thread overview]
Message-ID: <20220808133046.GA2347272@roeck-us.net> (raw)
In-Reply-To: <20220802020819.1226454-1-sunliming@kylinos.cn>
On Tue, Aug 02, 2022 at 10:08:19AM +0800, sunliming wrote:
> This symbol is not used outside of sa1100_wdt.c, so marks it static.
>
> Fixes the following warning:
>
> >> drivers/watchdog/sa1100_wdt.c:241:24: sparse: sparse: symbol 'sa1100dog_driver'
> was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sa1100_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/sa1100_wdt.c b/drivers/watchdog/sa1100_wdt.c
> index 2d0a06a158a8..82ac5d19f519 100644
> --- a/drivers/watchdog/sa1100_wdt.c
> +++ b/drivers/watchdog/sa1100_wdt.c
> @@ -238,7 +238,7 @@ static int sa1100dog_remove(struct platform_device *pdev)
> return 0;
> }
>
> -struct platform_driver sa1100dog_driver = {
> +static struct platform_driver sa1100dog_driver = {
> .driver.name = "sa1100_wdt",
> .probe = sa1100dog_probe,
> .remove = sa1100dog_remove,
> --
> 2.25.1
>
prev parent reply other threads:[~2022-08-08 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 2:08 sunliming
2022-08-02 8:09 ` Arnd Bergmann
2022-08-08 13:30 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220808133046.GA2347272@roeck-us.net \
--to=linux@roeck-us.net \
--cc=arnd@arndb.de \
--cc=kelulanainsley@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sunliming@kylinos.cn \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®