* [PATCH] watchdog: sa1100: make variable sa1100dog_driver static
@ 2022-08-02 2:08 sunliming
2022-08-02 8:09 ` Arnd Bergmann
2022-08-08 13:30 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: sunliming @ 2022-08-02 2:08 UTC (permalink / raw)
To: wim, linux, arnd
Cc: linux-watchdog, linux-kernel, kelulanainsley, sunliming,
kernel test robot
This symbol is not used outside of sa1100_wdt.c, so marks it static.
Fixes the following warning:
>> drivers/watchdog/sa1100_wdt.c:241:24: sparse: sparse: symbol 'sa1100dog_driver'
was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
drivers/watchdog/sa1100_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/sa1100_wdt.c b/drivers/watchdog/sa1100_wdt.c
index 2d0a06a158a8..82ac5d19f519 100644
--- a/drivers/watchdog/sa1100_wdt.c
+++ b/drivers/watchdog/sa1100_wdt.c
@@ -238,7 +238,7 @@ static int sa1100dog_remove(struct platform_device *pdev)
return 0;
}
-struct platform_driver sa1100dog_driver = {
+static struct platform_driver sa1100dog_driver = {
.driver.name = "sa1100_wdt",
.probe = sa1100dog_probe,
.remove = sa1100dog_remove,
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: sa1100: make variable sa1100dog_driver static
2022-08-02 2:08 [PATCH] watchdog: sa1100: make variable sa1100dog_driver static sunliming
@ 2022-08-02 8:09 ` Arnd Bergmann
2022-08-08 13:30 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2022-08-02 8:09 UTC (permalink / raw)
To: sunliming
Cc: Wim Van Sebroeck, Guenter Roeck, Arnd Bergmann, LINUXWATCHDOG,
Linux Kernel Mailing List, kelulanainsley, kernel test robot
On Tue, Aug 2, 2022 at 4:08 AM sunliming <sunliming@kylinos.cn> wrote:
>
> This symbol is not used outside of sa1100_wdt.c, so marks it static.
>
> Fixes the following warning:
>
> >> drivers/watchdog/sa1100_wdt.c:241:24: sparse: sparse: symbol 'sa1100dog_driver'
> was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] watchdog: sa1100: make variable sa1100dog_driver static
2022-08-02 2:08 [PATCH] watchdog: sa1100: make variable sa1100dog_driver static sunliming
2022-08-02 8:09 ` Arnd Bergmann
@ 2022-08-08 13:30 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2022-08-08 13:30 UTC (permalink / raw)
To: sunliming
Cc: wim, arnd, linux-watchdog, linux-kernel, kelulanainsley,
kernel test robot
On Tue, Aug 02, 2022 at 10:08:19AM +0800, sunliming wrote:
> This symbol is not used outside of sa1100_wdt.c, so marks it static.
>
> Fixes the following warning:
>
> >> drivers/watchdog/sa1100_wdt.c:241:24: sparse: sparse: symbol 'sa1100dog_driver'
> was not declared. Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: sunliming <sunliming@kylinos.cn>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/sa1100_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/sa1100_wdt.c b/drivers/watchdog/sa1100_wdt.c
> index 2d0a06a158a8..82ac5d19f519 100644
> --- a/drivers/watchdog/sa1100_wdt.c
> +++ b/drivers/watchdog/sa1100_wdt.c
> @@ -238,7 +238,7 @@ static int sa1100dog_remove(struct platform_device *pdev)
> return 0;
> }
>
> -struct platform_driver sa1100dog_driver = {
> +static struct platform_driver sa1100dog_driver = {
> .driver.name = "sa1100_wdt",
> .probe = sa1100dog_probe,
> .remove = sa1100dog_remove,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-08 13:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 2:08 [PATCH] watchdog: sa1100: make variable sa1100dog_driver static sunliming
2022-08-02 8:09 ` Arnd Bergmann
2022-08-08 13:30 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®