* [PATCH] crypto: axis: artpec6_crypto: move spin_lock_bh to spin_lock in tasklet
@ 2022-08-14 13:00 Tuo Cao
2022-08-19 11:05 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Tuo Cao @ 2022-08-14 13:00 UTC (permalink / raw)
To: jesper.nilsson, lars.persson, herbert, davem
Cc: linux-arm-kernel, linux-crypto, linux-kernel, 91tuocao
it is unnecessary to call spin_lock_bh in a tasklet.
Signed-off-by: Tuo Cao <91tuocao@gmail.com>
---
drivers/crypto/axis/artpec6_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
index 9ad188cffd0d..b4820594ab80 100644
--- a/drivers/crypto/axis/artpec6_crypto.c
+++ b/drivers/crypto/axis/artpec6_crypto.c
@@ -2091,7 +2091,7 @@ static void artpec6_crypto_task(unsigned long data)
return;
}
- spin_lock_bh(&ac->queue_lock);
+ spin_lock(&ac->queue_lock);
list_for_each_entry_safe(req, n, &ac->pending, list) {
struct artpec6_crypto_dma_descriptors *dma = req->dma;
@@ -2128,7 +2128,7 @@ static void artpec6_crypto_task(unsigned long data)
artpec6_crypto_process_queue(ac, &complete_in_progress);
- spin_unlock_bh(&ac->queue_lock);
+ spin_unlock(&ac->queue_lock);
/* Perform the completion callbacks without holding the queue lock
* to allow new request submissions from the callbacks.
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: axis: artpec6_crypto: move spin_lock_bh to spin_lock in tasklet
2022-08-14 13:00 [PATCH] crypto: axis: artpec6_crypto: move spin_lock_bh to spin_lock in tasklet Tuo Cao
@ 2022-08-19 11:05 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-08-19 11:05 UTC (permalink / raw)
To: Tuo Cao
Cc: jesper.nilsson, lars.persson, davem, linux-arm-kernel,
linux-crypto, linux-kernel
On Sun, Aug 14, 2022 at 09:00:54PM +0800, Tuo Cao wrote:
> it is unnecessary to call spin_lock_bh in a tasklet.
>
> Signed-off-by: Tuo Cao <91tuocao@gmail.com>
> ---
> drivers/crypto/axis/artpec6_crypto.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-19 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-14 13:00 [PATCH] crypto: axis: artpec6_crypto: move spin_lock_bh to spin_lock in tasklet Tuo Cao
2022-08-19 11:05 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®