mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chengming Zhou <zhouchengming@bytedance.com>
To: vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
	mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org,
	bsegall@google.com, vschneid@redhat.com
Cc: linux-kernel@vger.kernel.org, tj@kernel.org,
	Chengming Zhou <zhouchengming@bytedance.com>
Subject: [PATCH v6 1/9] sched/fair: maintain task se depth in set_task_rq()
Date: Thu, 18 Aug 2022 20:47:57 +0800	[thread overview]
Message-ID: <20220818124805.601-2-zhouchengming@bytedance.com> (raw)
In-Reply-To: <20220818124805.601-1-zhouchengming@bytedance.com>

Previously we only maintain task se depth in task_move_group_fair(),
if a !fair task change task group, its se depth will not be updated,
so commit eb7a59b2c888 ("sched/fair: Reset se-depth when task switched to FAIR")
fix the problem by updating se depth in switched_to_fair() too.

Then commit daa59407b558 ("sched/fair: Unify switched_{from,to}_fair()
and task_move_group_fair()") unified these two functions, moved se.depth
setting to attach_task_cfs_rq(), which further into attach_entity_cfs_rq()
with commit df217913e72e ("sched/fair: Factorize attach/detach entity").

This patch move task se depth maintenance from attach_entity_cfs_rq()
to set_task_rq(), which will be called when CPU/cgroup change, so its
depth will always be correct.

This patch is preparation for the next patch.

Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 kernel/sched/fair.c  | 8 --------
 kernel/sched/sched.h | 1 +
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a71d6686149b..c5ee08b187ec 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -11726,14 +11726,6 @@ static void attach_entity_cfs_rq(struct sched_entity *se)
 {
 	struct cfs_rq *cfs_rq = cfs_rq_of(se);
 
-#ifdef CONFIG_FAIR_GROUP_SCHED
-	/*
-	 * Since the real-depth could have been changed (only FAIR
-	 * class maintain depth value), reset depth properly.
-	 */
-	se->depth = se->parent ? se->parent->depth + 1 : 0;
-#endif
-
 	/* Synchronize entity with its cfs_rq */
 	update_load_avg(cfs_rq, se, sched_feat(ATTACH_AGE_LOAD) ? 0 : SKIP_AGE_LOAD);
 	attach_entity_load_avg(cfs_rq, se);
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index ddcfc7837595..628ffa974123 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1932,6 +1932,7 @@ static inline void set_task_rq(struct task_struct *p, unsigned int cpu)
 	set_task_rq_fair(&p->se, p->se.cfs_rq, tg->cfs_rq[cpu]);
 	p->se.cfs_rq = tg->cfs_rq[cpu];
 	p->se.parent = tg->se[cpu];
+	p->se.depth = tg->se[cpu] ? tg->se[cpu]->depth + 1 : 0;
 #endif
 
 #ifdef CONFIG_RT_GROUP_SCHED
-- 
2.37.2


  reply	other threads:[~2022-08-18 12:48 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 12:47 [PATCH v6 0/9] sched/fair: task load tracking optimization and cleanup Chengming Zhou
2022-08-18 12:47 ` Chengming Zhou [this message]
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Maintain task se depth in set_task_rq() tip-bot2 for Chengming Zhou
2022-08-18 12:47 ` [PATCH v6 2/9] sched/fair: remove redundant cpu_cgrp_subsys->fork() Chengming Zhou
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Chengming Zhou
2022-08-18 12:47 ` [PATCH v6 3/9] sched/fair: reset sched_avg last_update_time before set_task_rq() Chengming Zhou
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Reset " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 4/9] sched/fair: update comments in enqueue/dequeue_entity() Chengming Zhou
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Update " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 5/9] sched/fair: combine detach into dequeue when migrating task Chengming Zhou
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Combine " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 6/9] sched/fair: fix another detach on unattached task corner case Chengming Zhou
2022-08-23  7:06   ` Vincent Guittot
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Fix " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 7/9] sched/fair: allow changing cgroup of new forked task Chengming Zhou
2022-08-23  7:54   ` Vincent Guittot
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Allow " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 8/9] sched/fair: move task sched_avg attach to enqueue_task_fair() Chengming Zhou
2022-08-23  7:48   ` Vincent Guittot
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Move " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 9/9] sched/fair: don't init util/runnable_avg for !fair task Chengming Zhou
2022-08-23  7:49   ` Vincent Guittot
2022-08-23  9:27   ` [tip: sched/core] sched/fair: Don't " tip-bot2 for Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220818124805.601-2-zhouchengming@bytedance.com \
    --to=zhouchengming@bytedance.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®