From: Chengming Zhou <zhouchengming@bytedance.com>
To: vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org,
bsegall@google.com, vschneid@redhat.com
Cc: linux-kernel@vger.kernel.org, tj@kernel.org,
Chengming Zhou <zhouchengming@bytedance.com>
Subject: [PATCH v6 3/9] sched/fair: reset sched_avg last_update_time before set_task_rq()
Date: Thu, 18 Aug 2022 20:47:59 +0800 [thread overview]
Message-ID: <20220818124805.601-4-zhouchengming@bytedance.com> (raw)
In-Reply-To: <20220818124805.601-1-zhouchengming@bytedance.com>
set_task_rq() -> set_task_rq_fair() will try to synchronize the blocked
task's sched_avg when migrate, which is not needed for already detached
task.
task_change_group_fair() will detached the task sched_avg from prev cfs_rq
first, so reset sched_avg last_update_time before set_task_rq() to avoid that.
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4b95599aa951..5a704109472a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -11824,12 +11824,12 @@ void init_cfs_rq(struct cfs_rq *cfs_rq)
static void task_change_group_fair(struct task_struct *p)
{
detach_task_cfs_rq(p);
- set_task_rq(p, task_cpu(p));
#ifdef CONFIG_SMP
/* Tell se's cfs_rq has been changed -- migrated */
p->se.avg.last_update_time = 0;
#endif
+ set_task_rq(p, task_cpu(p));
attach_task_cfs_rq(p);
}
--
2.37.2
next prev parent reply other threads:[~2022-08-18 12:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 12:47 [PATCH v6 0/9] sched/fair: task load tracking optimization and cleanup Chengming Zhou
2022-08-18 12:47 ` [PATCH v6 1/9] sched/fair: maintain task se depth in set_task_rq() Chengming Zhou
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Maintain " tip-bot2 for Chengming Zhou
2022-08-18 12:47 ` [PATCH v6 2/9] sched/fair: remove redundant cpu_cgrp_subsys->fork() Chengming Zhou
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Chengming Zhou
2022-08-18 12:47 ` Chengming Zhou [this message]
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Reset sched_avg last_update_time before set_task_rq() tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 4/9] sched/fair: update comments in enqueue/dequeue_entity() Chengming Zhou
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Update " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 5/9] sched/fair: combine detach into dequeue when migrating task Chengming Zhou
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Combine " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 6/9] sched/fair: fix another detach on unattached task corner case Chengming Zhou
2022-08-23 7:06 ` Vincent Guittot
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Fix " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 7/9] sched/fair: allow changing cgroup of new forked task Chengming Zhou
2022-08-23 7:54 ` Vincent Guittot
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Allow " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 8/9] sched/fair: move task sched_avg attach to enqueue_task_fair() Chengming Zhou
2022-08-23 7:48 ` Vincent Guittot
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Move " tip-bot2 for Chengming Zhou
2022-08-18 12:48 ` [PATCH v6 9/9] sched/fair: don't init util/runnable_avg for !fair task Chengming Zhou
2022-08-23 7:49 ` Vincent Guittot
2022-08-23 9:27 ` [tip: sched/core] sched/fair: Don't " tip-bot2 for Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818124805.601-4-zhouchengming@bytedance.com \
--to=zhouchengming@bytedance.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®