From: Marco Felsch <m.felsch@pengutronix.de>
To: mchehab@kernel.org, sakari.ailus@linux.intel.com,
laurent.pinchart+renesas@ideasonboard.com,
jacopo+renesas@jmondi.org, akinobu.mita@gmail.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: [PATCH 4/4] media: mt9m111: remove .s_power callback
Date: Thu, 18 Aug 2022 16:47:12 +0200 [thread overview]
Message-ID: <20220818144712.997477-4-m.felsch@pengutronix.de> (raw)
In-Reply-To: <20220818144712.997477-1-m.felsch@pengutronix.de>
This is in preparation of switching to the generic dev PM mechanism.
Since the .s_power callback will be removed in the near future move the
powering into the .s_stream callback. So this driver no longer depends
on the .s_power mechanism.
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
drivers/media/i2c/mt9m111.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index cd74c408e110..8e8ba5a8e6ea 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers/media/i2c/mt9m111.c
@@ -1065,7 +1065,6 @@ static const struct v4l2_ctrl_ops mt9m111_ctrl_ops = {
};
static const struct v4l2_subdev_core_ops mt9m111_subdev_core_ops = {
- .s_power = mt9m111_s_power,
.log_status = v4l2_ctrl_subdev_log_status,
.subscribe_event = v4l2_ctrl_subdev_subscribe_event,
.unsubscribe_event = v4l2_event_subdev_unsubscribe,
@@ -1136,8 +1135,14 @@ static int mt9m111_enum_mbus_code(struct v4l2_subdev *sd,
static int mt9m111_s_stream(struct v4l2_subdev *sd, int enable)
{
struct mt9m111 *mt9m111 = container_of(sd, struct mt9m111, subdev);
+ int ret;
mt9m111->is_streaming = !!enable;
+
+ ret = mt9m111_s_power(sd, enable);
+ if (ret)
+ return ret;
+
return 0;
}
--
2.30.2
next prev parent reply other threads:[~2022-08-18 14:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 14:47 [PATCH 1/4] media: mt9m111: add V4L2_CID_PIXEL_RATE support Marco Felsch
2022-08-18 14:47 ` [PATCH 2/4] media: mt9m111: fix subdev API usage Marco Felsch
2022-08-19 7:16 ` Jacopo Mondi
2022-08-19 7:28 ` Marco Felsch
2022-08-19 7:40 ` Jacopo Mondi
2022-08-22 6:28 ` Sakari Ailus
2022-08-22 7:51 ` Marco Felsch
2022-08-22 9:17 ` Sakari Ailus
2022-08-18 14:47 ` [PATCH 3/4] media: mt9m111: fix device power usage Marco Felsch
2022-08-19 7:26 ` Jacopo Mondi
2022-08-19 7:32 ` Marco Felsch
2022-08-22 6:31 ` Sakari Ailus
2022-08-22 7:54 ` Marco Felsch
2022-08-22 9:18 ` Sakari Ailus
2022-08-23 14:44 ` Marco Felsch
2023-01-16 22:14 ` Sakari Ailus
2023-01-17 11:29 ` Marco Felsch
2023-01-17 11:32 ` Sakari Ailus
2022-08-18 14:47 ` Marco Felsch [this message]
2022-08-18 16:14 ` [PATCH 4/4] media: mt9m111: remove .s_power callback Jacopo Mondi
2022-08-19 7:18 ` Marco Felsch
2022-08-19 7:35 ` Jacopo Mondi
2022-08-19 8:06 ` Marco Felsch
2022-08-19 8:17 ` Jacopo Mondi
2022-08-18 16:11 ` [PATCH 1/4] media: mt9m111: add V4L2_CID_PIXEL_RATE support Jacopo Mondi
2022-08-19 7:56 ` Marco Felsch
2022-08-19 8:15 ` Jacopo Mondi
2022-08-19 9:04 ` Marco Felsch
2022-08-19 9:46 ` Jacopo Mondi
2022-08-19 10:06 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818144712.997477-4-m.felsch@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=akinobu.mita@gmail.com \
--cc=jacopo+renesas@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®