mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Joel Fernandes (Google)" <joel@joelfernandes.org>
To: linux-kernel@vger.kernel.org
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
	paulmck@kernel.org,
	Rushikesh S Kadam <rushikesh.s.kadam@intel.com>,
	"Uladzislau Rezki (Sony)" <urezki@gmail.com>,
	Neeraj upadhyay <neeraj.iitr10@gmail.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>, rcu <rcu@vger.kernel.org>,
	vineeth@bitbyteword.org
Subject: [PATCH v4 08/14] security: Move call_rcu() to call_rcu_lazy()
Date: Fri, 19 Aug 2022 20:48:51 +0000	[thread overview]
Message-ID: <20220819204857.3066329-9-joel@joelfernandes.org> (raw)
In-Reply-To: <20220819204857.3066329-1-joel@joelfernandes.org>

This is required to prevent callbacks triggering RCU machinery too
quickly and too often, which adds more power to the system.

Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
---
 security/security.c    | 2 +-
 security/selinux/avc.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/security/security.c b/security/security.c
index ea7163c20751..d76f4951b2bd 100644
--- a/security/security.c
+++ b/security/security.c
@@ -1053,7 +1053,7 @@ void security_inode_free(struct inode *inode)
 	 * The inode will be freed after the RCU grace period too.
 	 */
 	if (inode->i_security)
-		call_rcu((struct rcu_head *)inode->i_security,
+		call_rcu_lazy((struct rcu_head *)inode->i_security,
 				inode_free_by_rcu);
 }
 
diff --git a/security/selinux/avc.c b/security/selinux/avc.c
index 9a43af0ebd7d..381f046d820f 100644
--- a/security/selinux/avc.c
+++ b/security/selinux/avc.c
@@ -442,7 +442,7 @@ static void avc_node_free(struct rcu_head *rhead)
 static void avc_node_delete(struct selinux_avc *avc, struct avc_node *node)
 {
 	hlist_del_rcu(&node->list);
-	call_rcu(&node->rhead, avc_node_free);
+	call_rcu_lazy(&node->rhead, avc_node_free);
 	atomic_dec(&avc->avc_cache.active_nodes);
 }
 
@@ -458,7 +458,7 @@ static void avc_node_replace(struct selinux_avc *avc,
 			     struct avc_node *new, struct avc_node *old)
 {
 	hlist_replace_rcu(&old->list, &new->list);
-	call_rcu(&old->rhead, avc_node_free);
+	call_rcu_lazy(&old->rhead, avc_node_free);
 	atomic_dec(&avc->avc_cache.active_nodes);
 }
 
-- 
2.37.2.609.g9ff673ca1a-goog


  parent reply	other threads:[~2022-08-19 20:49 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 20:48 [PATCH v4 00/14] Implement call_rcu_lazy() and miscellaneous fixes Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 01/14] rcu: Introduce call_rcu_lazy() API implementation Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 02/14] rcu: shrinker for lazy rcu Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 03/14] rcuscale: Add laziness and kfree tests Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 04/14] fs: Move call_rcu() to call_rcu_lazy() in some paths Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 05/14] rcutorture: Add test code for call_rcu_lazy() Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 06/14] debug: Toggle lazy at runtime and change flush jiffies Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 07/14] cred: Move call_rcu() to call_rcu_lazy() Joel Fernandes (Google)
2022-08-19 20:48 ` Joel Fernandes (Google) [this message]
2022-08-19 20:48 ` [PATCH v4 09/14] net/core: " Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 10/14] kernel: Move various core kernel usages " Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 11/14] lib: Move call_rcu() " Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 12/14] i915: " Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 13/14] fork: Move thread_stack_free_rcu to call_rcu_lazy Joel Fernandes (Google)
2022-08-19 20:48 ` [PATCH v4 14/14] rcu/tree: Move trace_rcu_callback() before bypassing Joel Fernandes (Google)
2022-08-29 13:40 ` [PATCH v4 00/14] Implement call_rcu_lazy() and miscellaneous fixes Frederic Weisbecker
2022-08-29 16:45   ` Joel Fernandes
2022-08-29 19:46     ` Frederic Weisbecker
2022-08-29 20:31       ` Paul E. McKenney
2022-08-29 20:54         ` Joel Fernandes
2022-08-30 10:50         ` Frederic Weisbecker
2022-08-30 11:47           ` Paul E. McKenney
2022-08-29 20:36       ` Joel Fernandes
2022-08-29 20:42         ` Paul E. McKenney
2022-08-29 20:48           ` Joel Fernandes
2022-08-30 10:57             ` Frederic Weisbecker
2022-08-30 10:53           ` Frederic Weisbecker
2022-08-30 11:43             ` Paul E. McKenney
2022-08-30 16:03               ` Frederic Weisbecker
2022-08-30 16:22                 ` Frederic Weisbecker
2022-08-30 16:44                   ` Uladzislau Rezki
2022-08-30 18:53                     ` Joel Fernandes
2022-09-01 11:29                     ` Frederic Weisbecker
2022-09-01 11:59                       ` Uladzislau Rezki
2022-09-01 14:41                         ` Paul E. McKenney
2022-09-01 15:30                           ` Frederic Weisbecker
2022-09-01 16:11                             ` Joel Fernandes
2022-09-01 16:52                             ` Paul E. McKenney
2022-09-01 15:13                         ` Frederic Weisbecker
2022-09-01 16:07                           ` Joel Fernandes
2022-08-30 16:46                   ` Paul E. McKenney
2022-08-31 15:26                     ` Frederic Weisbecker
2022-09-01 14:39                       ` Paul E. McKenney
2022-09-01 14:58                         ` Frederic Weisbecker
2022-09-01 16:07                           ` Joel Fernandes
2022-09-01 16:49                             ` Paul E. McKenney
2022-09-01 18:28                               ` Frederic Weisbecker
2022-09-01 20:36                                 ` Paul E. McKenney
2022-08-30 18:46                   ` Joel Fernandes
2022-08-30 10:26         ` Frederic Weisbecker
2022-08-30 18:40           ` Joel Fernandes
2022-08-29 19:57     ` Paul E. McKenney
2022-08-30 10:43       ` Frederic Weisbecker
2022-08-30 12:08         ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220819204857.3066329-9-joel@joelfernandes.org \
    --to=joel@joelfernandes.org \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.iitr10@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=rushikesh.s.kadam@intel.com \
    --cc=urezki@gmail.com \
    --cc=vineeth@bitbyteword.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®