mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH next] audit: fix potential double free on error path from fsnotify_add_inode_mark
@ 2022-08-22  2:29 Gaosheng Cui
  2022-08-22  8:50 ` Jan Kara
  0 siblings, 1 reply; 8+ messages in thread
From: Gaosheng Cui @ 2022-08-22  2:29 UTC (permalink / raw)
  To: paul, eparis, mszeredi, jack, amir73il, cuigaosheng1
  Cc: linux-audit, linux-kernel

Audit_alloc_mark() assign pathname to audit_mark->path, on error path
from fsnotify_add_inode_mark(), fsnotify_put_mark will free memory
of audit_mark->path, but the caller of audit_alloc_mark will free
the pathname again, so there will be double free problem.

Fix this by resetting audit_mark->path to NULL pointer on error path
from fsnotify_add_inode_mark().

Fixes: 7b1293234084d ("fsnotify: Add group pointer in fsnotify_init_mark()")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 kernel/audit_fsnotify.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
index 6432a37ac1c9..c565fbf66ac8 100644
--- a/kernel/audit_fsnotify.c
+++ b/kernel/audit_fsnotify.c
@@ -102,6 +102,7 @@ struct audit_fsnotify_mark *audit_alloc_mark(struct audit_krule *krule, char *pa
 
 	ret = fsnotify_add_inode_mark(&audit_mark->mark, inode, 0);
 	if (ret < 0) {
+		audit_mark->path = NULL;
 		fsnotify_put_mark(&audit_mark->mark);
 		audit_mark = ERR_PTR(ret);
 	}
-- 
2.25.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-08-23  2:06 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-22  2:29 [PATCH next] audit: fix potential double free on error path from fsnotify_add_inode_mark Gaosheng Cui
2022-08-22  8:50 ` Jan Kara
2022-08-22 14:34   ` Paul Moore
2022-08-22 15:20     ` Jan Kara
2022-08-22 17:39       ` Paul Moore
2022-08-22 17:59         ` Jan Kara
2022-08-22 22:49           ` Paul Moore
2022-08-23  2:06             ` cuigaosheng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®