* [PATCH v1] drivers/acpi/processor_idle: check the return value of acpi_fetch_acpi_dev()
@ 2022-08-28 20:54 Li Zhong
2022-08-29 13:56 ` Rafael J. Wysocki
2022-09-10 16:10 ` Rafael J. Wysocki
0 siblings, 2 replies; 5+ messages in thread
From: Li Zhong @ 2022-08-28 20:54 UTC (permalink / raw)
To: linux-kernel, linux-acpi; +Cc: rafael, lenb, Li Zhong
The return value of acpi_fetch_acpi_dev() could be NULL, which will
cause null pointer dereference if used in acpi_device_hid().
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/acpi/processor_idle.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 16a1663d02d4..519f8f741da3 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -1117,6 +1117,8 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr)
status = acpi_get_parent(handle, &pr_ahandle);
while (ACPI_SUCCESS(status)) {
d = acpi_fetch_acpi_dev(pr_ahandle);
+ if (!d)
+ break;
handle = pr_ahandle;
if (strcmp(acpi_device_hid(d), ACPI_PROCESSOR_CONTAINER_HID))
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] drivers/acpi/processor_idle: check the return value of acpi_fetch_acpi_dev()
2022-08-28 20:54 [PATCH v1] drivers/acpi/processor_idle: check the return value of acpi_fetch_acpi_dev() Li Zhong
@ 2022-08-29 13:56 ` Rafael J. Wysocki
2022-09-03 23:03 ` Li Zhong
2022-09-10 16:10 ` Rafael J. Wysocki
1 sibling, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-08-29 13:56 UTC (permalink / raw)
To: Li Zhong
Cc: Linux Kernel Mailing List, ACPI Devel Maling List,
Rafael J. Wysocki, Len Brown
On Sun, Aug 28, 2022 at 10:54 PM Li Zhong <floridsleeves@gmail.com> wrote:
>
> The return value of acpi_fetch_acpi_dev() could be NULL, which will
> cause null pointer dereference if used in acpi_device_hid().
That's true.
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
> drivers/acpi/processor_idle.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 16a1663d02d4..519f8f741da3 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -1117,6 +1117,8 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr)
> status = acpi_get_parent(handle, &pr_ahandle);
> while (ACPI_SUCCESS(status)) {
> d = acpi_fetch_acpi_dev(pr_ahandle);
> + if (!d)
> + break;
But shouldn't this be continue?
> handle = pr_ahandle;
>
> if (strcmp(acpi_device_hid(d), ACPI_PROCESSOR_CONTAINER_HID))
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] drivers/acpi/processor_idle: check the return value of acpi_fetch_acpi_dev()
2022-08-29 13:56 ` Rafael J. Wysocki
@ 2022-09-03 23:03 ` Li Zhong
0 siblings, 0 replies; 5+ messages in thread
From: Li Zhong @ 2022-09-03 23:03 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linux Kernel Mailing List, ACPI Devel Maling List, Len Brown
On Mon, Aug 29, 2022 at 6:56 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Sun, Aug 28, 2022 at 10:54 PM Li Zhong <floridsleeves@gmail.com> wrote:
> >
> > The return value of acpi_fetch_acpi_dev() could be NULL, which will
> > cause null pointer dereference if used in acpi_device_hid().
>
> That's true.
>
> > Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> > ---
> > drivers/acpi/processor_idle.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> > index 16a1663d02d4..519f8f741da3 100644
> > --- a/drivers/acpi/processor_idle.c
> > +++ b/drivers/acpi/processor_idle.c
> > @@ -1117,6 +1117,8 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr)
> > status = acpi_get_parent(handle, &pr_ahandle);
> > while (ACPI_SUCCESS(status)) {
> > d = acpi_fetch_acpi_dev(pr_ahandle);
> > + if (!d)
> > + break;
>
> But shouldn't this be continue?
>
I think here is break instead of continue because if we use continue, variable
status will not change. Then the while condition will stay true and loop
forever.
> > handle = pr_ahandle;
> >
> > if (strcmp(acpi_device_hid(d), ACPI_PROCESSOR_CONTAINER_HID))
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] drivers/acpi/processor_idle: check the return value of acpi_fetch_acpi_dev()
2022-08-28 20:54 [PATCH v1] drivers/acpi/processor_idle: check the return value of acpi_fetch_acpi_dev() Li Zhong
2022-08-29 13:56 ` Rafael J. Wysocki
@ 2022-09-10 16:10 ` Rafael J. Wysocki
1 sibling, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-09-10 16:10 UTC (permalink / raw)
To: Li Zhong
Cc: Linux Kernel Mailing List, ACPI Devel Maling List,
Rafael J. Wysocki, Len Brown
On Sun, Aug 28, 2022 at 10:54 PM Li Zhong <floridsleeves@gmail.com> wrote:
>
> The return value of acpi_fetch_acpi_dev() could be NULL, which will
> cause null pointer dereference if used in acpi_device_hid().
>
> Signed-off-by: Li Zhong <floridsleeves@gmail.com>
> ---
> drivers/acpi/processor_idle.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index 16a1663d02d4..519f8f741da3 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -1117,6 +1117,8 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr)
> status = acpi_get_parent(handle, &pr_ahandle);
> while (ACPI_SUCCESS(status)) {
> d = acpi_fetch_acpi_dev(pr_ahandle);
> + if (!d)
> + break;
> handle = pr_ahandle;
>
> if (strcmp(acpi_device_hid(d), ACPI_PROCESSOR_CONTAINER_HID))
> --
Applied (with some edits in the subject and changelog) as 6.1 material, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v1] drivers/acpi/processor_idle: check the return value of acpi_fetch_acpi_dev()
@ 2022-09-02 7:37 Li Zhong
0 siblings, 0 replies; 5+ messages in thread
From: Li Zhong @ 2022-09-02 7:37 UTC (permalink / raw)
To: linux-acpi, linux-kernel; +Cc: rafael, lenb, Li Zhong
The return value of acpi_fetch_acpi_dev() could be NULL, which will
cause null pointer dereference if used in acpi_device_hid().
Signed-off-by: Li Zhong <floridsleeves@gmail.com>
---
drivers/acpi/processor_idle.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index 16a1663d02d4..519f8f741da3 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -1117,6 +1117,8 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr)
status = acpi_get_parent(handle, &pr_ahandle);
while (ACPI_SUCCESS(status)) {
d = acpi_fetch_acpi_dev(pr_ahandle);
+ if (!d)
+ break;
handle = pr_ahandle;
if (strcmp(acpi_device_hid(d), ACPI_PROCESSOR_CONTAINER_HID))
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-10 16:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-28 20:54 [PATCH v1] drivers/acpi/processor_idle: check the return value of acpi_fetch_acpi_dev() Li Zhong
2022-08-29 13:56 ` Rafael J. Wysocki
2022-09-03 23:03 ` Li Zhong
2022-09-10 16:10 ` Rafael J. Wysocki
2022-09-02 7:37 Li Zhong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®