From: kernel test robot <lkp@intel.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
mingo@redhat.com, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
vschneid@redhat.com, linux-kernel@vger.kernel.org,
parth@linux.ibm.com
Cc: kbuild-all@lists.01.org, qais.yousef@arm.com,
chris.hyser@oracle.com, valentin.schneider@arm.com,
patrick.bellasi@matbug.net, David.Laight@aculab.com,
pjt@google.com, pavel@ucw.cz, tj@kernel.org, qperret@google.com,
tim.c.chen@linux.intel.com, joshdon@google.com,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH v3 8/8] sched/fair: Add latency list
Date: Sat, 10 Sep 2022 00:07:54 +0800 [thread overview]
Message-ID: <202209092349.DjjxV7GB-lkp@intel.com> (raw)
In-Reply-To: <20220909130309.25458-9-vincent.guittot@linaro.org>
Hi Vincent,
I love your patch! Perhaps something to improve:
[auto build test WARNING on tip/sched/core]
[also build test WARNING on linus/master v6.0-rc4 next-20220909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Vincent-Guittot/Add-latency-priority-for-CFS-class/20220909-210655
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git fb04563d1cae6f361892b4a339ad92100b1eb0d0
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20220909/202209092349.DjjxV7GB-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4bdc6637b9aab44577b65686a745a14b325f4c23
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Vincent-Guittot/Add-latency-priority-for-CFS-class/20220909-210655
git checkout 4bdc6637b9aab44577b65686a745a14b325f4c23
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash kernel/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> kernel/sched/fair.c:727:22: warning: no previous prototype for '__pick_first_latency' [-Wmissing-prototypes]
727 | struct sched_entity *__pick_first_latency(struct cfs_rq *cfs_rq)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:742:5: warning: no previous prototype for 'sched_update_scaling' [-Wmissing-prototypes]
742 | int sched_update_scaling(void)
| ^~~~~~~~~~~~~~~~~~~~
vim +/__pick_first_latency +727 kernel/sched/fair.c
726
> 727 struct sched_entity *__pick_first_latency(struct cfs_rq *cfs_rq)
728 {
729 struct rb_node *left = rb_first_cached(&cfs_rq->latency_timeline);
730
731 if (!left)
732 return NULL;
733
734 return __latency_node_2_se(left);
735 }
736
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-09 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 13:03 [PATCH v3 0/8] Add latency priority for CFS class Vincent Guittot
2022-09-09 13:03 ` [PATCH v3 1/8] sched: Introduce latency-nice as a per-task attribute Vincent Guittot
2022-09-09 13:03 ` [PATCH v3 2/8] sched/core: Propagate parent task's latency requirements to the child task Vincent Guittot
2022-09-09 13:03 ` [PATCH v3 3/8] sched: Allow sched_{get,set}attr to change latency_nice of the task Vincent Guittot
2022-09-09 13:03 ` [PATCH v3 4/8] sched/core: Add permission checks for setting the latency_nice value Vincent Guittot
2022-09-09 13:03 ` [PATCH v3 5/8] sched/fair: Take into account latency priority at wakeup Vincent Guittot
2022-09-10 6:32 ` kernel test robot
2022-09-09 13:03 ` [PATCH v3 6/8] sched/fair: Add sched group latency support Vincent Guittot
2022-09-12 22:18 ` Tejun Heo
2022-09-13 8:31 ` Vincent Guittot
2022-09-09 13:03 ` [PATCH v3 7/8] sched/core: support latency priority with sched core Vincent Guittot
2022-09-09 13:03 ` [PATCH v3 8/8] sched/fair: Add latency list Vincent Guittot
2022-09-09 16:07 ` kernel test robot [this message]
2022-09-10 6:32 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209092349.DjjxV7GB-lkp@intel.com \
--to=lkp@intel.com \
--cc=David.Laight@aculab.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chris.hyser@oracle.com \
--cc=dietmar.eggemann@arm.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=parth@linux.ibm.com \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=pjt@google.com \
--cc=qais.yousef@arm.com \
--cc=qperret@google.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=tj@kernel.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®