* [PATCH 2/5] drm/amd/display: make dscl32_calc_lb_num_partitions static
2022-09-13 8:38 [PATCH 1/5] drm/amd/display: make enc32_stream_encoder_dvi_set_stream_attribute static Jiapeng Chong
@ 2022-09-13 8:38 ` Jiapeng Chong
2022-09-13 8:38 ` [PATCH 3/5] drm/amd/display: make dcn32_link_encoder_is_in_alt_mode and dcn32_link_encoder_get_max_link_cap static Jiapeng Chong
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-09-13 8:38 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
This symbol is not used outside of dcn32_dpp.c, so marks it static.
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_dpp.c:34:6: warning: no previous prototype for ‘dscl32_calc_lb_num_partitions’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2118
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dpp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dpp.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dpp.c
index f349cbe2a0f0..dcf12a0b031c 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dpp.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dpp.c
@@ -31,7 +31,7 @@
#include "dcn30/dcn30_cm_common.h"
/* Compute the maximum number of lines that we can fit in the line buffer */
-void dscl32_calc_lb_num_partitions(
+static void dscl32_calc_lb_num_partitions(
const struct scaler_data *scl_data,
enum lb_memory_config lb_config,
int *num_part_y,
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/5] drm/amd/display: make dcn32_link_encoder_is_in_alt_mode and dcn32_link_encoder_get_max_link_cap static
2022-09-13 8:38 [PATCH 1/5] drm/amd/display: make enc32_stream_encoder_dvi_set_stream_attribute static Jiapeng Chong
2022-09-13 8:38 ` [PATCH 2/5] drm/amd/display: make dscl32_calc_lb_num_partitions static Jiapeng Chong
@ 2022-09-13 8:38 ` Jiapeng Chong
2022-09-13 8:38 ` [PATCH 4/5] drm/amd/display: make mpc32_program_shaper and mpc32_program_3dlut static Jiapeng Chong
2022-09-13 8:38 ` [PATCH 5/5] drm/amd/display: Remove the unused function copy_stream_update_to_stream() Jiapeng Chong
3 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-09-13 8:38 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
These two functions are not used outside the function
dcn32_dio_link_encoder.c, so the modification is defined as static.
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_dio_link_encoder.c:121:6: warning: no previous prototype for ‘dcn32_link_encoder_is_in_alt_mode’.
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_dio_link_encoder.c:136:6: warning: no previous prototype for ‘dcn32_link_encoder_get_max_link_cap’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2117
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dio_link_encoder.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dio_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dio_link_encoder.c
index d6855d4f749b..fdae6aa89908 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dio_link_encoder.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_dio_link_encoder.c
@@ -118,7 +118,7 @@ void dcn32_link_encoder_enable_dp_output(
}
}
-bool dcn32_link_encoder_is_in_alt_mode(struct link_encoder *enc)
+static bool dcn32_link_encoder_is_in_alt_mode(struct link_encoder *enc)
{
struct dcn10_link_encoder *enc10 = TO_DCN10_LINK_ENC(enc);
uint32_t dp_alt_mode_disable = 0;
@@ -133,7 +133,7 @@ bool dcn32_link_encoder_is_in_alt_mode(struct link_encoder *enc)
return is_usb_c_alt_mode;
}
-void dcn32_link_encoder_get_max_link_cap(struct link_encoder *enc,
+static void dcn32_link_encoder_get_max_link_cap(struct link_encoder *enc,
struct dc_link_settings *link_settings)
{
struct dcn10_link_encoder *enc10 = TO_DCN10_LINK_ENC(enc);
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 4/5] drm/amd/display: make mpc32_program_shaper and mpc32_program_3dlut static
2022-09-13 8:38 [PATCH 1/5] drm/amd/display: make enc32_stream_encoder_dvi_set_stream_attribute static Jiapeng Chong
2022-09-13 8:38 ` [PATCH 2/5] drm/amd/display: make dscl32_calc_lb_num_partitions static Jiapeng Chong
2022-09-13 8:38 ` [PATCH 3/5] drm/amd/display: make dcn32_link_encoder_is_in_alt_mode and dcn32_link_encoder_get_max_link_cap static Jiapeng Chong
@ 2022-09-13 8:38 ` Jiapeng Chong
2022-09-13 8:38 ` [PATCH 5/5] drm/amd/display: Remove the unused function copy_stream_update_to_stream() Jiapeng Chong
3 siblings, 0 replies; 6+ messages in thread
From: Jiapeng Chong @ 2022-09-13 8:38 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
These two functions are not used outside the function dcn32_mpc.c, so the
modification is defined as static.
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:704:6: warning: no previous prototype for ‘mpc32_program_shaper’.
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn32/dcn32_mpc.c:900:6: warning: no previous prototype for ‘mpc32_program_3dlut’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2115
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
index 357bd2461bc9..f4bc77972c4e 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn32/dcn32_mpc.c
@@ -701,7 +701,7 @@ static void mpc32_power_on_shaper_3dlut(
}
-bool mpc32_program_shaper(
+static bool mpc32_program_shaper(
struct mpc *mpc,
const struct pwl_params *params,
uint32_t mpcc_id)
@@ -897,7 +897,7 @@ static void mpc32_set_3dlut_mode(
}
-bool mpc32_program_3dlut(
+static bool mpc32_program_3dlut(
struct mpc *mpc,
const struct tetrahedral_params *params,
int mpcc_id)
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 5/5] drm/amd/display: Remove the unused function copy_stream_update_to_stream()
2022-09-13 8:38 [PATCH 1/5] drm/amd/display: make enc32_stream_encoder_dvi_set_stream_attribute static Jiapeng Chong
` (2 preceding siblings ...)
2022-09-13 8:38 ` [PATCH 4/5] drm/amd/display: make mpc32_program_shaper and mpc32_program_3dlut static Jiapeng Chong
@ 2022-09-13 8:38 ` Jiapeng Chong
2022-09-13 13:01 ` Alex Deucher
3 siblings, 1 reply; 6+ messages in thread
From: Jiapeng Chong @ 2022-09-13 8:38 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
The function copy_stream_update_to_stream() is defined in the notif.c
file, but not called elsewhere, so delete this unused function.
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2852:6: warning: no previous prototype for ‘dc_reset_state’.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2113
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 9860bf38c547..2ee0b5a2ce62 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -2849,16 +2849,6 @@ static void copy_stream_update_to_stream(struct dc *dc,
}
}
-void dc_reset_state(struct dc *dc, struct dc_state *context)
-{
- dc_resource_state_destruct(context);
-
- /* clear the structure, but don't reset the reference count */
- memset(context, 0, offsetof(struct dc_state, refcount));
-
- init_state(dc, context);
-}
-
static bool update_planes_and_stream_state(struct dc *dc,
struct dc_surface_update *srf_updates, int surface_count,
struct dc_stream_state *stream,
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 5/5] drm/amd/display: Remove the unused function copy_stream_update_to_stream()
2022-09-13 8:38 ` [PATCH 5/5] drm/amd/display: Remove the unused function copy_stream_update_to_stream() Jiapeng Chong
@ 2022-09-13 13:01 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2022-09-13 13:01 UTC (permalink / raw)
To: Jiapeng Chong
Cc: alexander.deucher, airlied, Xinhui.Pan, Abaci Robot,
linux-kernel, dri-devel, amd-gfx, christian.koenig
Applied the series. Thanks!
Alex
On Tue, Sep 13, 2022 at 4:39 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> The function copy_stream_update_to_stream() is defined in the notif.c
> file, but not called elsewhere, so delete this unused function.
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:2852:6: warning: no previous prototype for ‘dc_reset_state’.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2113
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 9860bf38c547..2ee0b5a2ce62 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -2849,16 +2849,6 @@ static void copy_stream_update_to_stream(struct dc *dc,
> }
> }
>
> -void dc_reset_state(struct dc *dc, struct dc_state *context)
> -{
> - dc_resource_state_destruct(context);
> -
> - /* clear the structure, but don't reset the reference count */
> - memset(context, 0, offsetof(struct dc_state, refcount));
> -
> - init_state(dc, context);
> -}
> -
> static bool update_planes_and_stream_state(struct dc *dc,
> struct dc_surface_update *srf_updates, int surface_count,
> struct dc_stream_state *stream,
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 6+ messages in thread