* [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4
@ 2022-09-28 9:11 Jensen Huang
2022-10-17 12:34 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Jensen Huang @ 2022-09-28 9:11 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, Vinod Koul,
Chris Ruehl
Cc: Jensen Huang, devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled
by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode.
Tested on NanoPC-T4.
Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts")
Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com>
---
arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
index 278123b4f911..b6e082f1f6d9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-nanopi4.dtsi
@@ -167,6 +167,7 @@ &cpu_l3 {
};
&emmc_phy {
+ rockchip,enable-strobe-pulldown;
status = "okay";
};
--
2.37.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4
2022-09-28 9:11 [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4 Jensen Huang
@ 2022-10-17 12:34 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2022-10-17 12:34 UTC (permalink / raw)
To: Jensen Huang, Rob Herring, Chris Ruehl, Krzysztof Kozlowski, Vinod Koul
Cc: Heiko Stuebner, linux-arm-kernel, devicetree, linux-rockchip,
linux-kernel
On Wed, 28 Sep 2022 17:11:29 +0800, Jensen Huang wrote:
> Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled
> by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode.
>
> Tested on NanoPC-T4.
>
>
Applied, thanks!
[1/1] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4
commit: 463be3cb357dab7d7e4d8dcc7c15c642e10c5bef
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-17 12:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-28 9:11 [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on nanopi4 Jensen Huang
2022-10-17 12:34 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®