* [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'
@ 2022-09-29 9:10 Xin Hao
2022-09-29 21:36 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Xin Hao @ 2022-09-29 9:10 UTC (permalink / raw)
To: namit
Cc: tglx, peterz, mingo, bp, dave.hansen, x86, hpa, xhao, akpm, linux-kernel
Just correct the wrong word 'clleared' to 'cleared'
Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
---
arch/x86/include/asm/tlbflush.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
index cda3118f3b27..c80a15ef0cbc 100644
--- a/arch/x86/include/asm/tlbflush.h
+++ b/arch/x86/include/asm/tlbflush.h
@@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
diff &= ~_PAGE_ACCESSED;
/*
- * Did any of the 'flush_on_clear' flags was clleared set from between
+ * Did any of the 'flush_on_clear' flags was cleared set from between
* 'oldflags' and 'newflags'?
*/
if (diff & oldflags & flush_on_clear)
--
2.31.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'
2022-09-29 9:10 [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared' Xin Hao
@ 2022-09-29 21:36 ` Randy Dunlap
2022-09-29 22:58 ` Nadav Amit
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2022-09-29 21:36 UTC (permalink / raw)
To: Xin Hao, namit
Cc: tglx, peterz, mingo, bp, dave.hansen, x86, hpa, akpm, linux-kernel
Hi--
I would say let's fix the sentence grammar, but I don't know
what "cleared set" means.
On 9/29/22 02:10, Xin Hao wrote:
> Just correct the wrong word 'clleared' to 'cleared'
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
> ---
> arch/x86/include/asm/tlbflush.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index cda3118f3b27..c80a15ef0cbc 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
> diff &= ~_PAGE_ACCESSED;
>
> /*
> - * Did any of the 'flush_on_clear' flags was clleared set from between
> + * Did any of the 'flush_on_clear' flags was cleared set from between
It should be more like:
* Were any of the 'flush_on_clear' flags changed between
X86 people, does that make sense to you?
> * 'oldflags' and 'newflags'?
> */
> if (diff & oldflags & flush_on_clear)
> --
> 2.31.0
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'
2022-09-29 21:36 ` Randy Dunlap
@ 2022-09-29 22:58 ` Nadav Amit
2022-09-29 23:44 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Nadav Amit @ 2022-09-29 22:58 UTC (permalink / raw)
To: Randy Dunlap
Cc: Xin Hao, Thomas Gleixner, Peter Zijlstra (Intel),
Ingo Molnar, Borislav Petkov, Dave Hansen, X86 ML,
H. Peter Anvin, Andrew Morton, linux-kernel
On Sep 29, 2022, at 2:36 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
> ⚠ External Email
>
> Hi--
>
> I would say let's fix the sentence grammar, but I don't know
> what "cleared set" means.
>
>
> On 9/29/22 02:10, Xin Hao wrote:
>> Just correct the wrong word 'clleared' to 'cleared'
>>
>> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
>> ---
>> arch/x86/include/asm/tlbflush.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
>> index cda3118f3b27..c80a15ef0cbc 100644
>> --- a/arch/x86/include/asm/tlbflush.h
>> +++ b/arch/x86/include/asm/tlbflush.h
>> @@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
>> diff &= ~_PAGE_ACCESSED;
>>
>> /*
>> - * Did any of the 'flush_on_clear' flags was clleared set from between
>> + * Did any of the 'flush_on_clear' flags was cleared set from between
>
> It should be more like:
>
> * Were any of the 'flush_on_clear' flags changed between
>
> X86 people, does that make sense to you?
It’s not a test whether the flags are changed, but whether they are cleared.
Let’s see if we can make it clearer with shorter sentences. How about:
“Consider the ‘flush_on_clear’ flags that are set on ‘oldflags’; Flush if
any of these flags is cleared on ’newflags’”.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared'
2022-09-29 22:58 ` Nadav Amit
@ 2022-09-29 23:44 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2022-09-29 23:44 UTC (permalink / raw)
To: Nadav Amit
Cc: Xin Hao, Thomas Gleixner, Peter Zijlstra (Intel),
Ingo Molnar, Borislav Petkov, Dave Hansen, X86 ML,
H. Peter Anvin, Andrew Morton, linux-kernel
On 9/29/22 15:58, Nadav Amit wrote:
> On Sep 29, 2022, at 2:36 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>
>> ⚠ External Email
>>
>> Hi--
>>
>> I would say let's fix the sentence grammar, but I don't know
>> what "cleared set" means.
>>
>>
>> On 9/29/22 02:10, Xin Hao wrote:
>>> Just correct the wrong word 'clleared' to 'cleared'
>>>
>>> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
>>> ---
>>> arch/x86/include/asm/tlbflush.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
>>> index cda3118f3b27..c80a15ef0cbc 100644
>>> --- a/arch/x86/include/asm/tlbflush.h
>>> +++ b/arch/x86/include/asm/tlbflush.h
>>> @@ -291,7 +291,7 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
>>> diff &= ~_PAGE_ACCESSED;
>>>
>>> /*
>>> - * Did any of the 'flush_on_clear' flags was clleared set from between
>>> + * Did any of the 'flush_on_clear' flags was cleared set from between
>>
>> It should be more like:
>>
>> * Were any of the 'flush_on_clear' flags changed between
>>
>> X86 people, does that make sense to you?
>
> It’s not a test whether the flags are changed, but whether they are cleared.
>
> Let’s see if we can make it clearer with shorter sentences. How about:
> “Consider the ‘flush_on_clear’ flags that are set on ‘oldflags’; Flush if
> any of these flags is cleared on ’newflags’”.
>
Sounds good. Thanks for your help.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-29 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 9:10 [PATCH v2] x86/mm/tlb: fix error word 'clleared' to 'cleared' Xin Hao
2022-09-29 21:36 ` Randy Dunlap
2022-09-29 22:58 ` Nadav Amit
2022-09-29 23:44 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®