* [PATCH] loongarch: update config files
@ 2022-09-29 10:14 Lukas Bulwahn
2022-09-29 10:41 ` Huacai Chen
0 siblings, 1 reply; 8+ messages in thread
From: Lukas Bulwahn @ 2022-09-29 10:14 UTC (permalink / raw)
To: kernel-janitors, linux-kernel, Huacai Chen, WANG Xuerui, loongarch
Cc: Lukas Bulwahn
Clean up config files by:
- removing configs that were deleted in the past
- removing configs not in tree and without recently pending patches
- adding new configs that are replacements for old configs in the file
For some detailed information, see Link.
Link: https://lore.kernel.org/kernel-janitors/20220929090645.1389-1-lukas.bulwahn@gmail.com/
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/loongarch/configs/loongson3_defconfig | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/configs/loongson3_defconfig
index 3712552e18d3..2b4220778b66 100644
--- a/arch/loongarch/configs/loongson3_defconfig
+++ b/arch/loongarch/configs/loongson3_defconfig
@@ -108,14 +108,12 @@ CONFIG_NETFILTER=y
CONFIG_BRIDGE_NETFILTER=m
CONFIG_NETFILTER_NETLINK_LOG=m
CONFIG_NF_CONNTRACK=m
-CONFIG_NF_LOG_NETDEV=m
CONFIG_NF_CONNTRACK_AMANDA=m
CONFIG_NF_CONNTRACK_FTP=m
CONFIG_NF_CONNTRACK_NETBIOS_NS=m
CONFIG_NF_CONNTRACK_TFTP=m
CONFIG_NF_CT_NETLINK=m
CONFIG_NF_TABLES=m
-CONFIG_NFT_COUNTER=m
CONFIG_NFT_CONNLIMIT=m
CONFIG_NFT_LOG=m
CONFIG_NFT_LIMIT=m
@@ -329,7 +327,6 @@ CONFIG_PARPORT_PC_FIFO=y
CONFIG_ZRAM=m
CONFIG_ZRAM_DEF_COMP_ZSTD=y
CONFIG_BLK_DEV_LOOP=y
-CONFIG_BLK_DEV_CRYPTOLOOP=y
CONFIG_BLK_DEV_NBD=m
CONFIG_BLK_DEV_RAM=y
CONFIG_BLK_DEV_RAM_SIZE=8192
@@ -505,7 +502,6 @@ CONFIG_ATH9K_HTC=m
CONFIG_IWLWIFI=m
CONFIG_IWLDVM=m
CONFIG_IWLMVM=m
-CONFIG_IWLWIFI_BCAST_FILTERING=y
CONFIG_HOSTAP=m
CONFIG_MT7601U=m
CONFIG_RT2X00=m
@@ -688,7 +684,6 @@ CONFIG_COMEDI_NI_PCIDIO=m
CONFIG_COMEDI_NI_PCIMIO=m
CONFIG_STAGING=y
CONFIG_R8188EU=m
-# CONFIG_88EU_AP_MODE is not set
CONFIG_PM_DEVFREQ=y
CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
CONFIG_DEVFREQ_GOV_PERFORMANCE=y
@@ -772,14 +767,12 @@ CONFIG_CRYPTO_CRYPTD=m
CONFIG_CRYPTO_CHACHA20POLY1305=m
CONFIG_CRYPTO_HMAC=y
CONFIG_CRYPTO_VMAC=m
-CONFIG_CRYPTO_TGR192=m
CONFIG_CRYPTO_WP512=m
CONFIG_CRYPTO_ANUBIS=m
CONFIG_CRYPTO_BLOWFISH=m
CONFIG_CRYPTO_CAST5=m
CONFIG_CRYPTO_CAST6=m
CONFIG_CRYPTO_KHAZAD=m
-CONFIG_CRYPTO_SALSA20=m
CONFIG_CRYPTO_SEED=m
CONFIG_CRYPTO_SERPENT=m
CONFIG_CRYPTO_TEA=m
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loongarch: update config files
2022-09-29 10:14 [PATCH] loongarch: update config files Lukas Bulwahn
@ 2022-09-29 10:41 ` Huacai Chen
2022-09-29 10:44 ` Lukas Bulwahn
0 siblings, 1 reply; 8+ messages in thread
From: Huacai Chen @ 2022-09-29 10:41 UTC (permalink / raw)
To: Lukas Bulwahn; +Cc: kernel-janitors, linux-kernel, WANG Xuerui, loongarch
Hi, Lukas,
Thank you for your patch, it is queued for loongarch-next, and may be
squashed to another patch with your S-o-B if you have no objections.
Huacai
On Thu, Sep 29, 2022 at 6:14 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Clean up config files by:
> - removing configs that were deleted in the past
> - removing configs not in tree and without recently pending patches
> - adding new configs that are replacements for old configs in the file
>
> For some detailed information, see Link.
>
> Link: https://lore.kernel.org/kernel-janitors/20220929090645.1389-1-lukas.bulwahn@gmail.com/
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> arch/loongarch/configs/loongson3_defconfig | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/configs/loongson3_defconfig
> index 3712552e18d3..2b4220778b66 100644
> --- a/arch/loongarch/configs/loongson3_defconfig
> +++ b/arch/loongarch/configs/loongson3_defconfig
> @@ -108,14 +108,12 @@ CONFIG_NETFILTER=y
> CONFIG_BRIDGE_NETFILTER=m
> CONFIG_NETFILTER_NETLINK_LOG=m
> CONFIG_NF_CONNTRACK=m
> -CONFIG_NF_LOG_NETDEV=m
> CONFIG_NF_CONNTRACK_AMANDA=m
> CONFIG_NF_CONNTRACK_FTP=m
> CONFIG_NF_CONNTRACK_NETBIOS_NS=m
> CONFIG_NF_CONNTRACK_TFTP=m
> CONFIG_NF_CT_NETLINK=m
> CONFIG_NF_TABLES=m
> -CONFIG_NFT_COUNTER=m
> CONFIG_NFT_CONNLIMIT=m
> CONFIG_NFT_LOG=m
> CONFIG_NFT_LIMIT=m
> @@ -329,7 +327,6 @@ CONFIG_PARPORT_PC_FIFO=y
> CONFIG_ZRAM=m
> CONFIG_ZRAM_DEF_COMP_ZSTD=y
> CONFIG_BLK_DEV_LOOP=y
> -CONFIG_BLK_DEV_CRYPTOLOOP=y
> CONFIG_BLK_DEV_NBD=m
> CONFIG_BLK_DEV_RAM=y
> CONFIG_BLK_DEV_RAM_SIZE=8192
> @@ -505,7 +502,6 @@ CONFIG_ATH9K_HTC=m
> CONFIG_IWLWIFI=m
> CONFIG_IWLDVM=m
> CONFIG_IWLMVM=m
> -CONFIG_IWLWIFI_BCAST_FILTERING=y
> CONFIG_HOSTAP=m
> CONFIG_MT7601U=m
> CONFIG_RT2X00=m
> @@ -688,7 +684,6 @@ CONFIG_COMEDI_NI_PCIDIO=m
> CONFIG_COMEDI_NI_PCIMIO=m
> CONFIG_STAGING=y
> CONFIG_R8188EU=m
> -# CONFIG_88EU_AP_MODE is not set
> CONFIG_PM_DEVFREQ=y
> CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
> CONFIG_DEVFREQ_GOV_PERFORMANCE=y
> @@ -772,14 +767,12 @@ CONFIG_CRYPTO_CRYPTD=m
> CONFIG_CRYPTO_CHACHA20POLY1305=m
> CONFIG_CRYPTO_HMAC=y
> CONFIG_CRYPTO_VMAC=m
> -CONFIG_CRYPTO_TGR192=m
> CONFIG_CRYPTO_WP512=m
> CONFIG_CRYPTO_ANUBIS=m
> CONFIG_CRYPTO_BLOWFISH=m
> CONFIG_CRYPTO_CAST5=m
> CONFIG_CRYPTO_CAST6=m
> CONFIG_CRYPTO_KHAZAD=m
> -CONFIG_CRYPTO_SALSA20=m
> CONFIG_CRYPTO_SEED=m
> CONFIG_CRYPTO_SERPENT=m
> CONFIG_CRYPTO_TEA=m
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loongarch: update config files
2022-09-29 10:41 ` Huacai Chen
@ 2022-09-29 10:44 ` Lukas Bulwahn
2022-09-30 2:46 ` Huacai Chen
0 siblings, 1 reply; 8+ messages in thread
From: Lukas Bulwahn @ 2022-09-29 10:44 UTC (permalink / raw)
To: Huacai Chen; +Cc: kernel-janitors, linux-kernel, WANG Xuerui, loongarch
On Thu, Sep 29, 2022 at 12:42 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>
> Hi, Lukas,
>
> Thank you for your patch, it is queued for loongarch-next, and may be
> squashed to another patch with your S-o-B if you have no objections.
>
> Huacai
>
Feel free to squash as you see fit. I cannot recall sending something
specific for loongarch-next, though.
Lukas
> On Thu, Sep 29, 2022 at 6:14 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > Clean up config files by:
> > - removing configs that were deleted in the past
> > - removing configs not in tree and without recently pending patches
> > - adding new configs that are replacements for old configs in the file
> >
> > For some detailed information, see Link.
> >
> > Link: https://lore.kernel.org/kernel-janitors/20220929090645.1389-1-lukas.bulwahn@gmail.com/
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > arch/loongarch/configs/loongson3_defconfig | 7 -------
> > 1 file changed, 7 deletions(-)
> >
> > diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/configs/loongson3_defconfig
> > index 3712552e18d3..2b4220778b66 100644
> > --- a/arch/loongarch/configs/loongson3_defconfig
> > +++ b/arch/loongarch/configs/loongson3_defconfig
> > @@ -108,14 +108,12 @@ CONFIG_NETFILTER=y
> > CONFIG_BRIDGE_NETFILTER=m
> > CONFIG_NETFILTER_NETLINK_LOG=m
> > CONFIG_NF_CONNTRACK=m
> > -CONFIG_NF_LOG_NETDEV=m
> > CONFIG_NF_CONNTRACK_AMANDA=m
> > CONFIG_NF_CONNTRACK_FTP=m
> > CONFIG_NF_CONNTRACK_NETBIOS_NS=m
> > CONFIG_NF_CONNTRACK_TFTP=m
> > CONFIG_NF_CT_NETLINK=m
> > CONFIG_NF_TABLES=m
> > -CONFIG_NFT_COUNTER=m
> > CONFIG_NFT_CONNLIMIT=m
> > CONFIG_NFT_LOG=m
> > CONFIG_NFT_LIMIT=m
> > @@ -329,7 +327,6 @@ CONFIG_PARPORT_PC_FIFO=y
> > CONFIG_ZRAM=m
> > CONFIG_ZRAM_DEF_COMP_ZSTD=y
> > CONFIG_BLK_DEV_LOOP=y
> > -CONFIG_BLK_DEV_CRYPTOLOOP=y
> > CONFIG_BLK_DEV_NBD=m
> > CONFIG_BLK_DEV_RAM=y
> > CONFIG_BLK_DEV_RAM_SIZE=8192
> > @@ -505,7 +502,6 @@ CONFIG_ATH9K_HTC=m
> > CONFIG_IWLWIFI=m
> > CONFIG_IWLDVM=m
> > CONFIG_IWLMVM=m
> > -CONFIG_IWLWIFI_BCAST_FILTERING=y
> > CONFIG_HOSTAP=m
> > CONFIG_MT7601U=m
> > CONFIG_RT2X00=m
> > @@ -688,7 +684,6 @@ CONFIG_COMEDI_NI_PCIDIO=m
> > CONFIG_COMEDI_NI_PCIMIO=m
> > CONFIG_STAGING=y
> > CONFIG_R8188EU=m
> > -# CONFIG_88EU_AP_MODE is not set
> > CONFIG_PM_DEVFREQ=y
> > CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
> > CONFIG_DEVFREQ_GOV_PERFORMANCE=y
> > @@ -772,14 +767,12 @@ CONFIG_CRYPTO_CRYPTD=m
> > CONFIG_CRYPTO_CHACHA20POLY1305=m
> > CONFIG_CRYPTO_HMAC=y
> > CONFIG_CRYPTO_VMAC=m
> > -CONFIG_CRYPTO_TGR192=m
> > CONFIG_CRYPTO_WP512=m
> > CONFIG_CRYPTO_ANUBIS=m
> > CONFIG_CRYPTO_BLOWFISH=m
> > CONFIG_CRYPTO_CAST5=m
> > CONFIG_CRYPTO_CAST6=m
> > CONFIG_CRYPTO_KHAZAD=m
> > -CONFIG_CRYPTO_SALSA20=m
> > CONFIG_CRYPTO_SEED=m
> > CONFIG_CRYPTO_SERPENT=m
> > CONFIG_CRYPTO_TEA=m
> > --
> > 2.17.1
> >
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loongarch: update config files
2022-09-29 10:44 ` Lukas Bulwahn
@ 2022-09-30 2:46 ` Huacai Chen
2022-09-30 7:22 ` Lukas Bulwahn
2022-09-30 10:09 ` WANG Xuerui
0 siblings, 2 replies; 8+ messages in thread
From: Huacai Chen @ 2022-09-30 2:46 UTC (permalink / raw)
To: Lukas Bulwahn; +Cc: kernel-janitors, linux-kernel, WANG Xuerui, loongarch
On Thu, Sep 29, 2022 at 6:44 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> On Thu, Sep 29, 2022 at 12:42 PM Huacai Chen <chenhuacai@kernel.org> wrote:
> >
> > Hi, Lukas,
> >
> > Thank you for your patch, it is queued for loongarch-next, and may be
> > squashed to another patch with your S-o-B if you have no objections.
> >
> > Huacai
> >
>
> Feel free to squash as you see fit. I cannot recall sending something
> specific for loongarch-next, though.
Emmm, my meaning is squash your patch to mine and keep a S-o-B in that
patch [1]. :)
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next
Huacai
>
> Lukas
>
> > On Thu, Sep 29, 2022 at 6:14 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> > >
> > > Clean up config files by:
> > > - removing configs that were deleted in the past
> > > - removing configs not in tree and without recently pending patches
> > > - adding new configs that are replacements for old configs in the file
> > >
> > > For some detailed information, see Link.
> > >
> > > Link: https://lore.kernel.org/kernel-janitors/20220929090645.1389-1-lukas.bulwahn@gmail.com/
> > >
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > > arch/loongarch/configs/loongson3_defconfig | 7 -------
> > > 1 file changed, 7 deletions(-)
> > >
> > > diff --git a/arch/loongarch/configs/loongson3_defconfig b/arch/loongarch/configs/loongson3_defconfig
> > > index 3712552e18d3..2b4220778b66 100644
> > > --- a/arch/loongarch/configs/loongson3_defconfig
> > > +++ b/arch/loongarch/configs/loongson3_defconfig
> > > @@ -108,14 +108,12 @@ CONFIG_NETFILTER=y
> > > CONFIG_BRIDGE_NETFILTER=m
> > > CONFIG_NETFILTER_NETLINK_LOG=m
> > > CONFIG_NF_CONNTRACK=m
> > > -CONFIG_NF_LOG_NETDEV=m
> > > CONFIG_NF_CONNTRACK_AMANDA=m
> > > CONFIG_NF_CONNTRACK_FTP=m
> > > CONFIG_NF_CONNTRACK_NETBIOS_NS=m
> > > CONFIG_NF_CONNTRACK_TFTP=m
> > > CONFIG_NF_CT_NETLINK=m
> > > CONFIG_NF_TABLES=m
> > > -CONFIG_NFT_COUNTER=m
> > > CONFIG_NFT_CONNLIMIT=m
> > > CONFIG_NFT_LOG=m
> > > CONFIG_NFT_LIMIT=m
> > > @@ -329,7 +327,6 @@ CONFIG_PARPORT_PC_FIFO=y
> > > CONFIG_ZRAM=m
> > > CONFIG_ZRAM_DEF_COMP_ZSTD=y
> > > CONFIG_BLK_DEV_LOOP=y
> > > -CONFIG_BLK_DEV_CRYPTOLOOP=y
> > > CONFIG_BLK_DEV_NBD=m
> > > CONFIG_BLK_DEV_RAM=y
> > > CONFIG_BLK_DEV_RAM_SIZE=8192
> > > @@ -505,7 +502,6 @@ CONFIG_ATH9K_HTC=m
> > > CONFIG_IWLWIFI=m
> > > CONFIG_IWLDVM=m
> > > CONFIG_IWLMVM=m
> > > -CONFIG_IWLWIFI_BCAST_FILTERING=y
> > > CONFIG_HOSTAP=m
> > > CONFIG_MT7601U=m
> > > CONFIG_RT2X00=m
> > > @@ -688,7 +684,6 @@ CONFIG_COMEDI_NI_PCIDIO=m
> > > CONFIG_COMEDI_NI_PCIMIO=m
> > > CONFIG_STAGING=y
> > > CONFIG_R8188EU=m
> > > -# CONFIG_88EU_AP_MODE is not set
> > > CONFIG_PM_DEVFREQ=y
> > > CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
> > > CONFIG_DEVFREQ_GOV_PERFORMANCE=y
> > > @@ -772,14 +767,12 @@ CONFIG_CRYPTO_CRYPTD=m
> > > CONFIG_CRYPTO_CHACHA20POLY1305=m
> > > CONFIG_CRYPTO_HMAC=y
> > > CONFIG_CRYPTO_VMAC=m
> > > -CONFIG_CRYPTO_TGR192=m
> > > CONFIG_CRYPTO_WP512=m
> > > CONFIG_CRYPTO_ANUBIS=m
> > > CONFIG_CRYPTO_BLOWFISH=m
> > > CONFIG_CRYPTO_CAST5=m
> > > CONFIG_CRYPTO_CAST6=m
> > > CONFIG_CRYPTO_KHAZAD=m
> > > -CONFIG_CRYPTO_SALSA20=m
> > > CONFIG_CRYPTO_SEED=m
> > > CONFIG_CRYPTO_SERPENT=m
> > > CONFIG_CRYPTO_TEA=m
> > > --
> > > 2.17.1
> > >
> > >
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loongarch: update config files
2022-09-30 2:46 ` Huacai Chen
@ 2022-09-30 7:22 ` Lukas Bulwahn
2022-09-30 7:39 ` Conor.Dooley
2022-09-30 10:09 ` WANG Xuerui
1 sibling, 1 reply; 8+ messages in thread
From: Lukas Bulwahn @ 2022-09-30 7:22 UTC (permalink / raw)
To: Huacai Chen; +Cc: kernel-janitors, linux-kernel, WANG Xuerui, loongarch
On Fri, Sep 30, 2022 at 4:46 AM Huacai Chen <chenhuacai@kernel.org> wrote:
>
> On Thu, Sep 29, 2022 at 6:44 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > On Thu, Sep 29, 2022 at 12:42 PM Huacai Chen <chenhuacai@kernel.org> wrote:
> > >
> > > Hi, Lukas,
> > >
> > > Thank you for your patch, it is queued for loongarch-next, and may be
> > > squashed to another patch with your S-o-B if you have no objections.
> > >
> > > Huacai
> > >
> >
> > Feel free to squash as you see fit. I cannot recall sending something
> > specific for loongarch-next, though.
> Emmm, my meaning is squash your patch to mine and keep a S-o-B in that
> patch [1]. :)
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next
>
Process-wise that seems a bit strange (i.e., just mixing S-o-B by
multiple people, how do you bisect which individual change broke
something [you would need a second manual step of investigation],
etc.), but sure go ahead.
No objections.
Lukas
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loongarch: update config files
2022-09-30 7:22 ` Lukas Bulwahn
@ 2022-09-30 7:39 ` Conor.Dooley
2022-09-30 8:03 ` Huacai Chen
0 siblings, 1 reply; 8+ messages in thread
From: Conor.Dooley @ 2022-09-30 7:39 UTC (permalink / raw)
To: lukas.bulwahn, chenhuacai
Cc: kernel-janitors, linux-kernel, kernel, loongarch
On 30/09/2022 08:22, Lukas Bulwahn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Fri, Sep 30, 2022 at 4:46 AM Huacai Chen <chenhuacai@kernel.org> wrote:
>>
>> On Thu, Sep 29, 2022 at 6:44 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>>>
>>> On Thu, Sep 29, 2022 at 12:42 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>>>>
>>>> Hi, Lukas,
>>>>
>>>> Thank you for your patch, it is queued for loongarch-next, and may be
>>>> squashed to another patch with your S-o-B if you have no objections.
>>>>
>>>> Huacai
>>>>
>>>
>>> Feel free to squash as you see fit. I cannot recall sending something
>>> specific for loongarch-next, though.
>> Emmm, my meaning is squash your patch to mine and keep a S-o-B in that
>> patch [1]. :)
>>
>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next
>>
>
> Process-wise that seems a bit strange (i.e., just mixing S-o-B by
> multiple people, how do you bisect which individual change broke
> something [you would need a second manual step of investigation],
> etc.), but sure go ahead.
Looks like each of yourself, Youling and Tiezhu should also have
Co-developed-by tags, no?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loongarch: update config files
2022-09-30 7:39 ` Conor.Dooley
@ 2022-09-30 8:03 ` Huacai Chen
0 siblings, 0 replies; 8+ messages in thread
From: Huacai Chen @ 2022-09-30 8:03 UTC (permalink / raw)
To: Conor.Dooley
Cc: lukas.bulwahn, kernel-janitors, linux-kernel, kernel, loongarch
On Fri, Sep 30, 2022 at 3:39 PM <Conor.Dooley@microchip.com> wrote:
>
> On 30/09/2022 08:22, Lukas Bulwahn wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > On Fri, Sep 30, 2022 at 4:46 AM Huacai Chen <chenhuacai@kernel.org> wrote:
> >>
> >> On Thu, Sep 29, 2022 at 6:44 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >>>
> >>> On Thu, Sep 29, 2022 at 12:42 PM Huacai Chen <chenhuacai@kernel.org> wrote:
> >>>>
> >>>> Hi, Lukas,
> >>>>
> >>>> Thank you for your patch, it is queued for loongarch-next, and may be
> >>>> squashed to another patch with your S-o-B if you have no objections.
> >>>>
> >>>> Huacai
> >>>>
> >>>
> >>> Feel free to squash as you see fit. I cannot recall sending something
> >>> specific for loongarch-next, though.
> >> Emmm, my meaning is squash your patch to mine and keep a S-o-B in that
> >> patch [1]. :)
> >>
> >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next
> >>
> >
> > Process-wise that seems a bit strange (i.e., just mixing S-o-B by
> > multiple people, how do you bisect which individual change broke
> > something [you would need a second manual step of investigation],
> > etc.), but sure go ahead.
>
> Looks like each of yourself, Youling and Tiezhu should also have
> Co-developed-by tags, no?
Yes, that is needed.
Huacai
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] loongarch: update config files
2022-09-30 2:46 ` Huacai Chen
2022-09-30 7:22 ` Lukas Bulwahn
@ 2022-09-30 10:09 ` WANG Xuerui
1 sibling, 0 replies; 8+ messages in thread
From: WANG Xuerui @ 2022-09-30 10:09 UTC (permalink / raw)
To: Huacai Chen, Lukas Bulwahn; +Cc: kernel-janitors, linux-kernel, loongarch
On 9/30/22 10:46, Huacai Chen wrote:
> On Thu, Sep 29, 2022 at 6:44 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>> On Thu, Sep 29, 2022 at 12:42 PM Huacai Chen <chenhuacai@kernel.org> wrote:
>>> Hi, Lukas,
>>>
>>> Thank you for your patch, it is queued for loongarch-next, and may be
>>> squashed to another patch with your S-o-B if you have no objections.
>>>
>>> Huacai
>>>
>> Feel free to squash as you see fit. I cannot recall sending something
>> specific for loongarch-next, though.
> Emmm, my meaning is squash your patch to mine and keep a S-o-B in that
> patch [1]. :)
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next
>
Hi, I have to disagree with you in this case, you are mixing multiple
logical changes into one commit. Although all the commits are touching
the same Kconfig defaults file it doesn't mean they can be
unconditionally squashed. Especially when you have apparently dropped
Lukas' detailed explanation regarding the cleanups with one single
"Remove obsolete config options" sentence...
As you haven't created the tag and PR'd yet, I'd suggest you fix the
branch and just make the commits separate. At the very least please
don't delete Lukas' link reference regarding this round of overall
Kconfig cleanup effort.
--
WANG "xen0n" Xuerui
Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-09-30 10:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-29 10:14 [PATCH] loongarch: update config files Lukas Bulwahn
2022-09-29 10:41 ` Huacai Chen
2022-09-29 10:44 ` Lukas Bulwahn
2022-09-30 2:46 ` Huacai Chen
2022-09-30 7:22 ` Lukas Bulwahn
2022-09-30 7:39 ` Conor.Dooley
2022-09-30 8:03 ` Huacai Chen
2022-09-30 10:09 ` WANG Xuerui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®