* [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info
@ 2022-09-30 6:52 Zhang Changzhong
2022-09-30 6:57 ` Oleksij Rempel
2022-09-30 7:30 ` Marc Kleine-Budde
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Changzhong @ 2022-09-30 6:52 UTC (permalink / raw)
To: Robin van der Gracht, Oleksij Rempel, kernel, Oliver Hartkopp,
Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: Zhang Changzhong, linux-can, netdev, linux-kernel
Use "%s" instead of "%p" to print function name in debug info.
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
net/can/j1939/transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c
index d7d86c9..6ec48a4 100644
--- a/net/can/j1939/transport.c
+++ b/net/can/j1939/transport.c
@@ -985,7 +985,7 @@ static int j1939_session_tx_eoma(struct j1939_session *session)
/* wait for the EOMA packet to come in */
j1939_tp_set_rxtimeout(session, 1250);
- netdev_dbg(session->priv->ndev, "%p: 0x%p\n", __func__, session);
+ netdev_dbg(session->priv->ndev, "%s: 0x%p\n", __func__, session);
return 0;
}
--
2.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info
2022-09-30 6:52 [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info Zhang Changzhong
@ 2022-09-30 6:57 ` Oleksij Rempel
2022-09-30 7:30 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Oleksij Rempel @ 2022-09-30 6:57 UTC (permalink / raw)
To: Zhang Changzhong
Cc: Robin van der Gracht, Oleksij Rempel, kernel, Oliver Hartkopp,
Marc Kleine-Budde, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-can, netdev, linux-kernel
On Fri, Sep 30, 2022 at 02:52:08PM +0800, Zhang Changzhong wrote:
> Use "%s" instead of "%p" to print function name in debug info.
>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Thank you!
> ---
> net/can/j1939/transport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/can/j1939/transport.c b/net/can/j1939/transport.c
> index d7d86c9..6ec48a4 100644
> --- a/net/can/j1939/transport.c
> +++ b/net/can/j1939/transport.c
> @@ -985,7 +985,7 @@ static int j1939_session_tx_eoma(struct j1939_session *session)
> /* wait for the EOMA packet to come in */
> j1939_tp_set_rxtimeout(session, 1250);
>
> - netdev_dbg(session->priv->ndev, "%p: 0x%p\n", __func__, session);
> + netdev_dbg(session->priv->ndev, "%s: 0x%p\n", __func__, session);
>
> return 0;
> }
> --
> 2.9.5
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info
2022-09-30 6:52 [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info Zhang Changzhong
2022-09-30 6:57 ` Oleksij Rempel
@ 2022-09-30 7:30 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2022-09-30 7:30 UTC (permalink / raw)
To: Zhang Changzhong
Cc: Robin van der Gracht, Oleksij Rempel, kernel, Oliver Hartkopp,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-can, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On 30.09.2022 14:52:08, Zhang Changzhong wrote:
> Use "%s" instead of "%p" to print function name in debug info.
>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Applied to linux-can-next.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-30 7:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-30 6:52 [PATCH net-next] can: j1939: j1939_session_tx_eoma(): fix debug info Zhang Changzhong
2022-09-30 6:57 ` Oleksij Rempel
2022-09-30 7:30 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®