mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [kbuild] drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54 ngbe_shutdown() error: uninitialized symbol 'wake'.
@ 2022-10-05 10:05 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-10-05 10:05 UTC (permalink / raw)
  To: kbuild, Mengyuan Lou
  Cc: lkp, kbuild-all, linux-kernel, Paolo Abeni, Andrew Lunn

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git   master
head:   2bca25eaeba6190efbfcb38ed169bd7ee43b5aaf
commit: e79e40c83b9fd4e8b9b9d4fc9093d25b7a67c745 net: ngbe: Add build support for ngbe
config: powerpc-randconfig-m041-20221002
compiler: powerpc-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54 ngbe_shutdown() error: uninitialized symbol 'wake'.

vim +/wake +54 drivers/net/ethernet/wangxun/ngbe/ngbe_main.c

e79e40c83b9fd4 Mengyuan Lou 2022-08-26  47  static void ngbe_shutdown(struct pci_dev *pdev)
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  48  {
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  49  	bool wake;
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  50  
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  51  	ngbe_dev_shutdown(pdev, &wake);

ngbe_dev_shutdown() does not do anything to wake.

e79e40c83b9fd4 Mengyuan Lou 2022-08-26  52  
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  53  	if (system_state == SYSTEM_POWER_OFF) {
e79e40c83b9fd4 Mengyuan Lou 2022-08-26 @54  		pci_wake_from_d3(pdev, wake);
                                                                               ^^^^
Uninitialized.


e79e40c83b9fd4 Mengyuan Lou 2022-08-26  55  		pci_set_power_state(pdev, PCI_D3hot);
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  56  	}
e79e40c83b9fd4 Mengyuan Lou 2022-08-26  57  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp  


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-10-05 10:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-05 10:05 [kbuild] drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54 ngbe_shutdown() error: uninitialized symbol 'wake' Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®