* [PATCH linux-next] speakup: fix comparing pointer to 0
@ 2022-10-12 10:04 xu.panda668
0 siblings, 0 replies; only message in thread
From: xu.panda668 @ 2022-10-12 10:04 UTC (permalink / raw)
To: w.d.hubbs; +Cc: chris, kirk, linux-kernel, Xu Panda, Zeal Robot
From: Xu Panda <xu.panda@zte.com.cn>
Comparing pointer to NULL is more appropriate, and we usually compare int
to 0 and judge bool directly.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
---
drivers/accessibility/speakup/utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..a1792f3734ad 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
else
snprintf(filename, sizeof(filename), "%s", name);
infile = fopen(filename, "r");
- if (infile == 0) {
+ if (infile == NULL) {
fprintf(stderr, "can't open %s\n", filename);
exit(1);
}
--
2.15.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-12 10:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 10:04 [PATCH linux-next] speakup: fix comparing pointer to 0 xu.panda668
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®