* [PATCH] thermal: imx8mm_thermal: use GENMASK() when appropriate
@ 2022-10-14 8:16 Marcus Folkesson
2022-10-17 8:04 ` Peng Fan
0 siblings, 1 reply; 2+ messages in thread
From: Marcus Folkesson @ 2022-10-14 8:16 UTC (permalink / raw)
To: Rafael J . Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, Anson Huang
Cc: linux-pm, linux-arm-kernel, linux-kernel, Marcus Folkesson
GENMASK() is preferred to use for bitmasks.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/thermal/imx8mm_thermal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
index c5cd873c6e01..74fc34b88bb0 100644
--- a/drivers/thermal/imx8mm_thermal.c
+++ b/drivers/thermal/imx8mm_thermal.c
@@ -23,8 +23,8 @@
#define TER_ADC_PD BIT(30)
#define TER_EN BIT(31)
-#define TRITSR_TEMP0_VAL_MASK 0xff
-#define TRITSR_TEMP1_VAL_MASK 0xff0000
+#define TRITSR_TEMP0_VAL_MASK GENMASK(7, 0)
+#define TRITSR_TEMP1_VAL_MASK GENMASK(23, 16)
#define PROBE_SEL_ALL GENMASK(31, 30)
--
2.37.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal: imx8mm_thermal: use GENMASK() when appropriate
2022-10-14 8:16 [PATCH] thermal: imx8mm_thermal: use GENMASK() when appropriate Marcus Folkesson
@ 2022-10-17 8:04 ` Peng Fan
0 siblings, 0 replies; 2+ messages in thread
From: Peng Fan @ 2022-10-17 8:04 UTC (permalink / raw)
To: Marcus Folkesson, Rafael J . Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
Anson Huang
Cc: linux-pm, linux-arm-kernel, linux-kernel
On 10/14/2022 4:16 PM, Marcus Folkesson wrote:
> GENMASK() is preferred to use for bitmasks.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---
> drivers/thermal/imx8mm_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index c5cd873c6e01..74fc34b88bb0 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -23,8 +23,8 @@
>
> #define TER_ADC_PD BIT(30)
> #define TER_EN BIT(31)
> -#define TRITSR_TEMP0_VAL_MASK 0xff
> -#define TRITSR_TEMP1_VAL_MASK 0xff0000
> +#define TRITSR_TEMP0_VAL_MASK GENMASK(7, 0)
> +#define TRITSR_TEMP1_VAL_MASK GENMASK(23, 16)
>
> #define PROBE_SEL_ALL GENMASK(31, 30)
>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-17 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-14 8:16 [PATCH] thermal: imx8mm_thermal: use GENMASK() when appropriate Marcus Folkesson
2022-10-17 8:04 ` Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®