* [PATCH] fs/ntfs: remove redundant assignment to pointer m
@ 2022-10-17 21:33 Colin Ian King
2023-05-10 1:42 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-10-17 21:33 UTC (permalink / raw)
To: Anton Altaparmakov, linux-ntfs-dev; +Cc: kernel-janitors, linux-kernel
The pointer m is being assigned a value that is never read, it
is being re-assigned to a NULL later on. The assignment is
redundant and can be removed.
Cleans up clang scan build warning:
fs/ntfs/file.c:194:3: warning: Value stored to 'm' is never
read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
fs/ntfs/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c
index c481b14e4fd9..56d08374739a 100644
--- a/fs/ntfs/file.c
+++ b/fs/ntfs/file.c
@@ -191,7 +191,6 @@ static int ntfs_attr_extend_initialized(ntfs_inode *ni, const s64 new_init_size)
err = -EIO;
goto err_out;
}
- m = ctx->mrec;
a = ctx->attr;
BUG_ON(!a->non_resident);
BUG_ON(old_i_size != (loff_t)
--
2.37.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/ntfs: remove redundant assignment to pointer m
2022-10-17 21:33 [PATCH] fs/ntfs: remove redundant assignment to pointer m Colin Ian King
@ 2023-05-10 1:42 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2023-05-10 1:42 UTC (permalink / raw)
To: Colin Ian King
Cc: Anton Altaparmakov, linux-ntfs-dev, kernel-janitors,
Linux Kernel Mailing List, Christian Brauner
2022-10-18 6:33 GMT+09:00, Colin Ian King <colin.i.king@gmail.com>:
> The pointer m is being assigned a value that is never read, it
> is being re-assigned to a NULL later on. The assignment is
> redundant and can be removed.
>
> Cleans up clang scan build warning:
> fs/ntfs/file.c:194:3: warning: Value stored to 'm' is never
> read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-10 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-17 21:33 [PATCH] fs/ntfs: remove redundant assignment to pointer m Colin Ian King
2023-05-10 1:42 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®