* [PATCH v6 1/3] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker
2022-10-03 10:27 [PATCH v6 0/3] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
@ 2022-10-03 10:27 ` Sheng-Liang Pan
2022-10-05 16:43 ` Doug Anderson
2022-10-03 10:27 ` [PATCH v6 2/3] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-03 10:27 ` [PATCH v6 3/3] arm64: dts: qcom: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
2 siblings, 1 reply; 7+ messages in thread
From: Sheng-Liang Pan @ 2022-10-03 10:27 UTC (permalink / raw)
To: LKML
Cc: dianders, Sheng-Liang Pan, Krzysztof Kozlowski, Andy Gross,
Bjorn Andersson, Rob Herring, Stephen Boyd, devicetree,
linux-arm-msm
evoker will have WIFI/LTE SKU, separate it for each different setting.
Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v5)
Changes in v5:
- new patch add touchpad and touchscreen for evoker
- remove unnecessary whitespace
Changes in v4:
- fix typo in tittle and commit
- remove change for trackpad and touchscreen
Changes in v3:
- none
Changes in v2:
- none
Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 8060c35d003b4..c15a729a6852e 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -513,6 +513,11 @@ properties:
- const: google,evoker
- const: qcom,sc7280
+ - description: Google Evoker with LTE (newest rev)
+ items:
+ - const: google,evoker-sku512
+ - const: qcom,sc7280
+
- description: Google Herobrine (newest rev)
items:
- const: google,herobrine
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v6 1/3] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker
2022-10-03 10:27 ` [PATCH v6 1/3] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
@ 2022-10-05 16:43 ` Doug Anderson
0 siblings, 0 replies; 7+ messages in thread
From: Doug Anderson @ 2022-10-05 16:43 UTC (permalink / raw)
To: Sheng-Liang Pan
Cc: LKML, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Rob Herring, Stephen Boyd, devicetree, linux-arm-msm
Hi,
On Mon, Oct 3, 2022 at 3:28 AM Sheng-Liang Pan
<sheng-liang.pan@quanta.corp-partner.google.com> wrote:
>
> evoker will have WIFI/LTE SKU, separate it for each different setting.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v5)
>
> Changes in v5:
> - new patch add touchpad and touchscreen for evoker
> - remove unnecessary whitespace
>
> Changes in v4:
> - fix typo in tittle and commit
> - remove change for trackpad and touchscreen
No need to spin for this purpose, but your version history is a bit
confusing here. You should be putting the version history in the patch
that changed. In this case the bindings patch (patch #1) didn't change
in v5 and the trackpad/touchscreen didn't change in v4. Those changes
were in patches #2 and #3.
-Doug
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v6 2/3] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family
2022-10-03 10:27 [PATCH v6 0/3] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-03 10:27 ` [PATCH v6 1/3] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
@ 2022-10-03 10:27 ` Sheng-Liang Pan
2022-10-17 22:48 ` Bjorn Andersson
2022-10-03 10:27 ` [PATCH v6 3/3] arm64: dts: qcom: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
2 siblings, 1 reply; 7+ messages in thread
From: Sheng-Liang Pan @ 2022-10-03 10:27 UTC (permalink / raw)
To: LKML
Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson,
Rob Herring, devicetree, linux-arm-msm
evoker have wifi/lte sku, add different dts for each sku.
Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
(no changes since v5)
Changes in v5:
- remove unnecessary whitespace
Changes in v4:
- remove change for trackpad and touchscreen
arch/arm64/boot/dts/qcom/Makefile | 3 ++-
.../boot/dts/qcom/sc7280-herobrine-evoker-lte.dts | 14 ++++++++++++++
.../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 +++++++++++++++
...evoker-r0.dts => sc7280-herobrine-evoker.dtsi} | 7 -------
4 files changed, 31 insertions(+), 8 deletions(-)
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (98%)
diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index 65cb0f714ed6b..91153baeeffae 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -95,7 +95,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb
-dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-r0.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker.dtb
+dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-lte.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb
dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
new file mode 100644
index 0000000000000..3af9224a7492e
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Evoker board device tree source
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+#include "sc7280-herobrine-evoker.dts"
+#include "sc7280-herobrine-lte-sku.dtsi"
+
+/ {
+ model = "Google Evoker with LTE";
+ compatible = "google,evoker-sku512", "qcom,sc7280";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
new file mode 100644
index 0000000000000..dcdd4eecfe670
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Google Evoker board device tree source
+ *
+ * Copyright 2022 Google LLC.
+ */
+
+/dts-v1/;
+
+#include "sc7280-herobrine-evoker.dtsi"
+
+/ {
+ model = "Google Evoker";
+ compatible = "google,evoker", "qcom,sc7280";
+};
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
similarity index 98%
rename from arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts
rename to arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
index ccbe50b6249ab..e78072159d54b 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
@@ -5,15 +5,8 @@
* Copyright 2022 Google LLC.
*/
-/dts-v1/;
-
#include "sc7280-herobrine.dtsi"
-/ {
- model = "Google Evoker";
- compatible = "google,evoker", "qcom,sc7280";
-};
-
/*
* ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES
*
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v6 2/3] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family
2022-10-03 10:27 ` [PATCH v6 2/3] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
@ 2022-10-17 22:48 ` Bjorn Andersson
0 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2022-10-17 22:48 UTC (permalink / raw)
To: Sheng-Liang Pan
Cc: LKML, dianders, Andy Gross, Rob Herring, devicetree, linux-arm-msm
On Mon, Oct 03, 2022 at 06:27:35PM +0800, Sheng-Liang Pan wrote:
Please prefix your sc7280 changes with "arm64: dts: qcom: sc7280: "...
Regards,
Bjorn
> evoker have wifi/lte sku, add different dts for each sku.
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> (no changes since v5)
>
> Changes in v5:
> - remove unnecessary whitespace
>
> Changes in v4:
> - remove change for trackpad and touchscreen
>
> arch/arm64/boot/dts/qcom/Makefile | 3 ++-
> .../boot/dts/qcom/sc7280-herobrine-evoker-lte.dts | 14 ++++++++++++++
> .../boot/dts/qcom/sc7280-herobrine-evoker.dts | 15 +++++++++++++++
> ...evoker-r0.dts => sc7280-herobrine-evoker.dtsi} | 7 -------
> 4 files changed, 31 insertions(+), 8 deletions(-)
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
> create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
> rename arch/arm64/boot/dts/qcom/{sc7280-herobrine-evoker-r0.dts => sc7280-herobrine-evoker.dtsi} (98%)
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 65cb0f714ed6b..91153baeeffae 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -95,7 +95,8 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-r0.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-evoker-lte.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
> new file mode 100644
> index 0000000000000..3af9224a7492e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dts
> @@ -0,0 +1,14 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Evoker board device tree source
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +#include "sc7280-herobrine-evoker.dts"
> +#include "sc7280-herobrine-lte-sku.dtsi"
> +
> +/ {
> + model = "Google Evoker with LTE";
> + compatible = "google,evoker-sku512", "qcom,sc7280";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
> new file mode 100644
> index 0000000000000..dcdd4eecfe670
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dts
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Google Evoker board device tree source
> + *
> + * Copyright 2022 Google LLC.
> + */
> +
> +/dts-v1/;
> +
> +#include "sc7280-herobrine-evoker.dtsi"
> +
> +/ {
> + model = "Google Evoker";
> + compatible = "google,evoker", "qcom,sc7280";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> similarity index 98%
> rename from arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts
> rename to arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> index ccbe50b6249ab..e78072159d54b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> @@ -5,15 +5,8 @@
> * Copyright 2022 Google LLC.
> */
>
> -/dts-v1/;
> -
> #include "sc7280-herobrine.dtsi"
>
> -/ {
> - model = "Google Evoker";
> - compatible = "google,evoker", "qcom,sc7280";
> -};
> -
> /*
> * ADDITIONS TO FIXED REGULATORS DEFINED IN PARENT DEVICE TREE FILES
> *
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v6 3/3] arm64: dts: qcom: Add touchscreen and touchpad support for evoker
2022-10-03 10:27 [PATCH v6 0/3] Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
2022-10-03 10:27 ` [PATCH v6 1/3] dt-bindings: arm: qcom: Separate LTE/WIFI SKU for sc7280-evoker Sheng-Liang Pan
2022-10-03 10:27 ` [PATCH v6 2/3] arm64: dts: qcom: Add LTE SKU for sc7280-evoker family Sheng-Liang Pan
@ 2022-10-03 10:27 ` Sheng-Liang Pan
2022-10-05 16:47 ` Doug Anderson
2 siblings, 1 reply; 7+ messages in thread
From: Sheng-Liang Pan @ 2022-10-03 10:27 UTC (permalink / raw)
To: LKML
Cc: dianders, Sheng-Liang Pan, Andy Gross, Bjorn Andersson,
Rob Herring, devicetree, linux-arm-msm
Change touchpad and touchscreen node for evoker
Touchpad: SA461D-1011
Touchscreen: GT7986U
Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
---
Changes in v6:
- add removed pinctrl and align touchscreen label with herobrine board
Changes in v5:
- Touchscreen / trackpad patch new for v5
.../boot/dts/qcom/sc7280-herobrine-evoker.dtsi | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
index e78072159d54b..d1723fbffae67 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
@@ -23,16 +23,15 @@ ap_tp_i2c: &i2c0 {
status = "okay";
clock-frequency = <400000>;
- trackpad: trackpad@2c {
- compatible = "hid-over-i2c";
- reg = <0x2c>;
+ trackpad: trackpad@15 {
+ compatible = "elan,ekth3000";
+ reg = <0x15>;
pinctrl-names = "default";
pinctrl-0 = <&tp_int_odl>;
interrupt-parent = <&tlmm>;
interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
- hid-descr-addr = <0x20>;
vcc-supply = <&pp3300_z1>;
wakeup-source;
@@ -43,9 +42,9 @@ ts_i2c: &i2c13 {
status = "okay";
clock-frequency = <400000>;
- ap_ts: touchscreen@10 {
- compatible = "elan,ekth6915";
- reg = <0x10>;
+ ap_ts: touchscreen@5d {
+ compatible = "goodix,gt7375p";
+ reg = <0x5d>;
pinctrl-names = "default";
pinctrl-0 = <&ts_int_conn>, <&ts_rst_conn>;
@@ -54,7 +53,7 @@ ap_ts: touchscreen@10 {
reset-gpios = <&tlmm 54 GPIO_ACTIVE_LOW>;
- vcc33-supply = <&ts_avdd>;
+ vdd-supply = <&ts_avdd>;
};
};
--
2.34.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v6 3/3] arm64: dts: qcom: Add touchscreen and touchpad support for evoker
2022-10-03 10:27 ` [PATCH v6 3/3] arm64: dts: qcom: Add touchscreen and touchpad support for evoker Sheng-Liang Pan
@ 2022-10-05 16:47 ` Doug Anderson
0 siblings, 0 replies; 7+ messages in thread
From: Doug Anderson @ 2022-10-05 16:47 UTC (permalink / raw)
To: Sheng-Liang Pan
Cc: LKML, Andy Gross, Bjorn Andersson, Rob Herring, devicetree,
linux-arm-msm
Hi,
On Mon, Oct 3, 2022 at 3:28 AM Sheng-Liang Pan
<sheng-liang.pan@quanta.corp-partner.google.com> wrote:
>
> Change touchpad and touchscreen node for evoker
> Touchpad: SA461D-1011
> Touchscreen: GT7986U
>
> Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com>
> ---
>
> Changes in v6:
> - add removed pinctrl and align touchscreen label with herobrine board
>
> Changes in v5:
> - Touchscreen / trackpad patch new for v5
>
> .../boot/dts/qcom/sc7280-herobrine-evoker.dtsi | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> index e78072159d54b..d1723fbffae67 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtsi
> @@ -23,16 +23,15 @@ ap_tp_i2c: &i2c0 {
> status = "okay";
> clock-frequency = <400000>;
>
> - trackpad: trackpad@2c {
> - compatible = "hid-over-i2c";
> - reg = <0x2c>;
> + trackpad: trackpad@15 {
> + compatible = "elan,ekth3000";
> + reg = <0x15>;
> pinctrl-names = "default";
> pinctrl-0 = <&tp_int_odl>;
>
> interrupt-parent = <&tlmm>;
> interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
>
> - hid-descr-addr = <0x20>;
> vcc-supply = <&pp3300_z1>;
>
> wakeup-source;
> @@ -43,9 +42,9 @@ ts_i2c: &i2c13 {
> status = "okay";
> clock-frequency = <400000>;
>
> - ap_ts: touchscreen@10 {
> - compatible = "elan,ekth6915";
> - reg = <0x10>;
> + ap_ts: touchscreen@5d {
> + compatible = "goodix,gt7375p";
> + reg = <0x5d>;
You silently ignored my feedback here:
[1] https://lore.kernel.org/r/CAD=FV=XHr9Y6oQR19wVVHC6jzcd82hf1bHNbr62n89vuTbme9Q@mail.gmail.com
Did you not see it? Did you ignore it for a reason?
-Doug
^ permalink raw reply [flat|nested] 7+ messages in thread