* [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification
@ 2022-10-10 10:51 mikhail.kshevetskiy
2022-10-10 10:51 ` [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support mikhail.kshevetskiy
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: mikhail.kshevetskiy @ 2022-10-10 10:51 UTC (permalink / raw)
To: linux-kernel, linux-mtd
Cc: Mikhail Kshevetskiy, Vignesh Raghavendra, Richard Weinberger,
Miquel Raynal, Frieder Schrempf
From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
but current driver uses only first 2 bytes of it for devices
identification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
is identified as W25N01GV (id_bytes: EF, AA, 21).
Fix this by adding missed identification bytes.
Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
---
drivers/mtd/nand/spi/winbond.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c
index 76684428354e..ed368a55d68f 100644
--- a/drivers/mtd/nand/spi/winbond.c
+++ b/drivers/mtd/nand/spi/winbond.c
@@ -76,7 +76,7 @@ static int w25m02gv_select_target(struct spinand_device *spinand,
static const struct spinand_info winbond_spinand_table[] = {
SPINAND_INFO("W25M02GV",
- SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xab),
+ SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xab, 0x21),
NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 2),
NAND_ECCREQ(1, 512),
SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
@@ -86,7 +86,7 @@ static const struct spinand_info winbond_spinand_table[] = {
SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL),
SPINAND_SELECT_TARGET(w25m02gv_select_target)),
SPINAND_INFO("W25N01GV",
- SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xaa),
+ SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xaa, 0x21),
NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
NAND_ECCREQ(1, 512),
SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support
2022-10-10 10:51 [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification mikhail.kshevetskiy
@ 2022-10-10 10:51 ` mikhail.kshevetskiy
2022-10-10 10:59 ` Frieder Schrempf
2022-10-18 9:04 ` Miquel Raynal
2022-10-10 10:59 ` [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification Frieder Schrempf
2022-10-18 9:04 ` Miquel Raynal
2 siblings, 2 replies; 6+ messages in thread
From: mikhail.kshevetskiy @ 2022-10-10 10:51 UTC (permalink / raw)
To: linux-kernel, linux-mtd
Cc: Mikhail Kshevetskiy, Vignesh Raghavendra, Richard Weinberger,
Miquel Raynal, Frieder Schrempf
From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Add support of Winbond W25N02KV flash
Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
---
drivers/mtd/nand/spi/winbond.c | 75 ++++++++++++++++++++++++++++++++++
1 file changed, 75 insertions(+)
diff --git a/drivers/mtd/nand/spi/winbond.c b/drivers/mtd/nand/spi/winbond.c
index ed368a55d68f..3ad58cd284d8 100644
--- a/drivers/mtd/nand/spi/winbond.c
+++ b/drivers/mtd/nand/spi/winbond.c
@@ -74,6 +74,72 @@ static int w25m02gv_select_target(struct spinand_device *spinand,
return spi_mem_exec_op(spinand->spimem, &op);
}
+static int w25n02kv_ooblayout_ecc(struct mtd_info *mtd, int section,
+ struct mtd_oob_region *region)
+{
+ if (section > 3)
+ return -ERANGE;
+
+ region->offset = 64 + (16 * section);
+ region->length = 13;
+
+ return 0;
+}
+
+static int w25n02kv_ooblayout_free(struct mtd_info *mtd, int section,
+ struct mtd_oob_region *region)
+{
+ if (section > 3)
+ return -ERANGE;
+
+ region->offset = (16 * section) + 2;
+ region->length = 14;
+
+ return 0;
+}
+
+static const struct mtd_ooblayout_ops w25n02kv_ooblayout = {
+ .ecc = w25n02kv_ooblayout_ecc,
+ .free = w25n02kv_ooblayout_free,
+};
+
+static int w25n02kv_ecc_get_status(struct spinand_device *spinand,
+ u8 status)
+{
+ struct nand_device *nand = spinand_to_nand(spinand);
+ u8 mbf = 0;
+ struct spi_mem_op op = SPINAND_GET_FEATURE_OP(0x30, &mbf);
+
+ switch (status & STATUS_ECC_MASK) {
+ case STATUS_ECC_NO_BITFLIPS:
+ return 0;
+
+ case STATUS_ECC_UNCOR_ERROR:
+ return -EBADMSG;
+
+ case STATUS_ECC_HAS_BITFLIPS:
+ /*
+ * Let's try to retrieve the real maximum number of bitflips
+ * in order to avoid forcing the wear-leveling layer to move
+ * data around if it's not necessary.
+ */
+ if (spi_mem_exec_op(spinand->spimem, &op))
+ return nanddev_get_ecc_conf(nand)->strength;
+
+ mbf >>= 4;
+
+ if (WARN_ON(mbf > nanddev_get_ecc_conf(nand)->strength || !mbf))
+ return nanddev_get_ecc_conf(nand)->strength;
+
+ return mbf;
+
+ default:
+ break;
+ }
+
+ return -EINVAL;
+}
+
static const struct spinand_info winbond_spinand_table[] = {
SPINAND_INFO("W25M02GV",
SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xab, 0x21),
@@ -94,6 +160,15 @@ static const struct spinand_info winbond_spinand_table[] = {
&update_cache_variants),
0,
SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL)),
+ SPINAND_INFO("W25N02KV",
+ SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xaa, 0x22),
+ NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 1, 1, 1),
+ NAND_ECCREQ(8, 512),
+ SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+ &write_cache_variants,
+ &update_cache_variants),
+ 0,
+ SPINAND_ECCINFO(&w25n02kv_ooblayout, w25n02kv_ecc_get_status)),
};
static int winbond_spinand_init(struct spinand_device *spinand)
--
2.35.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support
2022-10-10 10:51 ` [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support mikhail.kshevetskiy
@ 2022-10-10 10:59 ` Frieder Schrempf
2022-10-18 9:04 ` Miquel Raynal
1 sibling, 0 replies; 6+ messages in thread
From: Frieder Schrempf @ 2022-10-10 10:59 UTC (permalink / raw)
To: mikhail.kshevetskiy, linux-kernel, linux-mtd
Cc: Vignesh Raghavendra, Richard Weinberger, Miquel Raynal
On 10.10.22 12:51, mikhail.kshevetskiy@iopsys.eu wrote:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
>
> Add support of Winbond W25N02KV flash
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support
2022-10-10 10:51 ` [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support mikhail.kshevetskiy
2022-10-10 10:59 ` Frieder Schrempf
@ 2022-10-18 9:04 ` Miquel Raynal
1 sibling, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2022-10-18 9:04 UTC (permalink / raw)
To: mikhail.kshevetskiy, linux-kernel, linux-mtd
Cc: Miquel Raynal, Vignesh Raghavendra, Richard Weinberger, Frieder Schrempf
On Mon, 2022-10-10 at 10:51:10 UTC, mikhail.kshevetskiy@iopsys.eu wrote:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
>
> Add support of Winbond W25N02KV flash
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification
2022-10-10 10:51 [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification mikhail.kshevetskiy
2022-10-10 10:51 ` [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support mikhail.kshevetskiy
@ 2022-10-10 10:59 ` Frieder Schrempf
2022-10-18 9:04 ` Miquel Raynal
2 siblings, 0 replies; 6+ messages in thread
From: Frieder Schrempf @ 2022-10-10 10:59 UTC (permalink / raw)
To: mikhail.kshevetskiy, linux-kernel, linux-mtd
Cc: Vignesh Raghavendra, Richard Weinberger, Miquel Raynal
On 10.10.22 12:51, mikhail.kshevetskiy@iopsys.eu wrote:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
>
> Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> but current driver uses only first 2 bytes of it for devices
> identification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
> is identified as W25N01GV (id_bytes: EF, AA, 21).
>
> Fix this by adding missed identification bytes.
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Thanks!
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification
2022-10-10 10:51 [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification mikhail.kshevetskiy
2022-10-10 10:51 ` [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support mikhail.kshevetskiy
2022-10-10 10:59 ` [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification Frieder Schrempf
@ 2022-10-18 9:04 ` Miquel Raynal
2 siblings, 0 replies; 6+ messages in thread
From: Miquel Raynal @ 2022-10-18 9:04 UTC (permalink / raw)
To: mikhail.kshevetskiy, linux-kernel, linux-mtd
Cc: Miquel Raynal, Vignesh Raghavendra, Richard Weinberger, Frieder Schrempf
On Mon, 2022-10-10 at 10:51:09 UTC, mikhail.kshevetskiy@iopsys.eu wrote:
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
>
> Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> but current driver uses only first 2 bytes of it for devices
> identification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
> is identified as W25N01GV (id_bytes: EF, AA, 21).
>
> Fix this by adding missed identification bytes.
>
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-10-18 9:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 10:51 [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification mikhail.kshevetskiy
2022-10-10 10:51 ` [PATCH v3 2/2] mtd: spinand: winbond: add Winbond W25N02KV flash support mikhail.kshevetskiy
2022-10-10 10:59 ` Frieder Schrempf
2022-10-18 9:04 ` Miquel Raynal
2022-10-10 10:59 ` [PATCH v3 1/2] mtd: spinand: winbond: fix flash identification Frieder Schrempf
2022-10-18 9:04 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®