* [PATCH] RDMA/hw/qib/qib_iba6120: Remove variable freeze_cnt
@ 2022-10-21 17:35 Colin Ian King
2022-10-24 11:32 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-10-21 17:35 UTC (permalink / raw)
To: Dennis Dalessandro, Jason Gunthorpe, Leon Romanovsky, linux-rdma
Cc: kernel-janitors, linux-kernel
The variable freeze_cnt being incremented but it is never referenced,
it is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/infiniband/hw/qib/qib_iba6120.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/qib/qib_iba6120.c b/drivers/infiniband/hw/qib/qib_iba6120.c
index aea571943768..23a81edf3f7a 100644
--- a/drivers/infiniband/hw/qib/qib_iba6120.c
+++ b/drivers/infiniband/hw/qib/qib_iba6120.c
@@ -799,12 +799,9 @@ static void qib_handle_6120_hwerrors(struct qib_devdata *dd, char *msg,
hwerrs &= ~TXE_PIO_PARITY;
}
- if (!hwerrs) {
- static u32 freeze_cnt;
-
- freeze_cnt++;
+ if (!hwerrs)
qib_6120_clear_freeze(dd);
- } else
+ else
isfatal = 1;
}
--
2.37.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] RDMA/hw/qib/qib_iba6120: Remove variable freeze_cnt
2022-10-21 17:35 [PATCH] RDMA/hw/qib/qib_iba6120: Remove variable freeze_cnt Colin Ian King
@ 2022-10-24 11:32 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2022-10-24 11:32 UTC (permalink / raw)
To: linux-rdma, Jason Gunthorpe, Colin Ian King, Dennis Dalessandro
Cc: linux-kernel, kernel-janitors
On Fri, 21 Oct 2022 18:35:04 +0100, Colin Ian King wrote:
> The variable freeze_cnt being incremented but it is never referenced,
> it is redundant and can be removed.
>
>
Applied, thanks!
[1/1] RDMA/hw/qib/qib_iba6120: Remove variable freeze_cnt
https://git.kernel.org/rdma/rdma/c/5dc1b37d75e713
Best regards,
--
Leon Romanovsky <leon@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-24 11:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-21 17:35 [PATCH] RDMA/hw/qib/qib_iba6120: Remove variable freeze_cnt Colin Ian King
2022-10-24 11:32 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®