From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-arch@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 02/10] kill coredump_params->regs
Date: Sun, 30 Oct 2022 00:18:42 +0100 [thread overview]
Message-ID: <20221029231850.3668437-2-viro@zeniv.linux.org.uk> (raw)
In-Reply-To: <20221029231850.3668437-1-viro@zeniv.linux.org.uk>
it's always task_pt_regs(current)
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
fs/binfmt_elf.c | 4 ++--
fs/coredump.c | 1 -
include/linux/coredump.h | 1 -
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 63c7ebb0da89..002fd713ac11 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -2082,7 +2082,7 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
/* now collect the dump for the current */
memset(info->prstatus, 0, sizeof(*info->prstatus));
fill_prstatus(&info->prstatus->common, current, cprm->siginfo->si_signo);
- elf_core_copy_regs(&info->prstatus->pr_reg, cprm->regs);
+ elf_core_copy_regs(&info->prstatus->pr_reg, task_pt_regs(current));
/* Set up header */
fill_elf_header(elf, phdrs, ELF_ARCH, ELF_CORE_EFLAGS);
@@ -2109,7 +2109,7 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
/* Try to dump the FPU. */
info->prstatus->pr_fpvalid =
- elf_core_copy_task_fpregs(current, cprm->regs, info->fpu);
+ elf_core_copy_task_fpregs(current, task_pt_regs(current), info->fpu);
if (info->prstatus->pr_fpvalid)
fill_note(info->notes + info->numnote++,
"CORE", NT_PRFPREG, sizeof(*info->fpu), info->fpu);
diff --git a/fs/coredump.c b/fs/coredump.c
index b4ec1bf889f9..1a474de1e52b 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -525,7 +525,6 @@ void do_coredump(const kernel_siginfo_t *siginfo)
static atomic_t core_dump_count = ATOMIC_INIT(0);
struct coredump_params cprm = {
.siginfo = siginfo,
- .regs = task_pt_regs(current),
.limit = rlimit(RLIMIT_CORE),
/*
* We must use the same mm->flags while dumping core to avoid
diff --git a/include/linux/coredump.h b/include/linux/coredump.h
index 08a1d3e7e46d..a0655d7c149c 100644
--- a/include/linux/coredump.h
+++ b/include/linux/coredump.h
@@ -18,7 +18,6 @@ struct core_vma_metadata {
struct coredump_params {
const kernel_siginfo_t *siginfo;
- struct pt_regs *regs;
struct file *file;
unsigned long limit;
unsigned long mm_flags;
--
2.30.2
next prev parent reply other threads:[~2022-10-29 23:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 23:16 [RFC][PATCHSET] coredump unification for regset and non-regset architectures Al Viro
2022-10-29 23:18 ` [PATCH 01/10] kill signal_pt_regs() Al Viro
2022-10-29 23:18 ` Al Viro [this message]
2022-10-29 23:18 ` [PATCH 03/10] kill extern of vsyscall32_sysctl Al Viro
2022-10-29 23:18 ` [PATCH 04/10] [elf][regset] clean fill_note_info() a bit Al Viro
2022-10-29 23:18 ` [PATCH 05/10] [elf][regset] simplify thread list handling in fill_note_info() Al Viro
2022-10-29 23:18 ` [PATCH 06/10] elf_core_copy_task_regs(): task_pt_regs is defined everywhere Al Viro
2022-10-29 23:18 ` [PATCH 07/10] [elf][non-regset] uninline elf_core_copy_task_fpregs() (and lose pt_regs argument) Al Viro
2022-11-08 9:41 ` Geert Uytterhoeven
2022-10-29 23:18 ` [PATCH 08/10] [elf][non-regset] use elf_core_copy_task_regs() for dumper as well Al Viro
2022-10-29 23:18 ` [PATCH 09/10] [elf] unify regset and non-regset cases Al Viro
2022-10-29 23:18 ` [PATCH 10/10] [elf] get rid of get_note_info_size() Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221029231850.3668437-2-viro@zeniv.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®