From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-arch@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 04/10] [elf][regset] clean fill_note_info() a bit
Date: Sun, 30 Oct 2022 00:18:44 +0100 [thread overview]
Message-ID: <20221029231850.3668437-4-viro@zeniv.linux.org.uk> (raw)
In-Reply-To: <20221029231850.3668437-1-viro@zeniv.linux.org.uk>
*info is already initialized...
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
fs/binfmt_elf.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
index 002fd713ac11..4190dafd2ec4 100644
--- a/fs/binfmt_elf.c
+++ b/fs/binfmt_elf.c
@@ -1833,24 +1833,17 @@ static int fill_note_info(struct elfhdr *elf, int phdrs,
struct elf_thread_core_info *t;
struct elf_prpsinfo *psinfo;
struct core_thread *ct;
- unsigned int i;
-
- info->size = 0;
- info->thread = NULL;
psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL);
- if (psinfo == NULL) {
- info->psinfo.data = NULL; /* So we don't free this wrongly */
+ if (!psinfo)
return 0;
- }
-
fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);
/*
* Figure out how many notes we're going to need for each thread.
*/
info->thread_notes = 0;
- for (i = 0; i < view->n; ++i)
+ for (int i = 0; i < view->n; ++i)
if (view->regsets[i].core_note_type != 0)
++info->thread_notes;
--
2.30.2
next prev parent reply other threads:[~2022-10-29 23:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 23:16 [RFC][PATCHSET] coredump unification for regset and non-regset architectures Al Viro
2022-10-29 23:18 ` [PATCH 01/10] kill signal_pt_regs() Al Viro
2022-10-29 23:18 ` [PATCH 02/10] kill coredump_params->regs Al Viro
2022-10-29 23:18 ` [PATCH 03/10] kill extern of vsyscall32_sysctl Al Viro
2022-10-29 23:18 ` Al Viro [this message]
2022-10-29 23:18 ` [PATCH 05/10] [elf][regset] simplify thread list handling in fill_note_info() Al Viro
2022-10-29 23:18 ` [PATCH 06/10] elf_core_copy_task_regs(): task_pt_regs is defined everywhere Al Viro
2022-10-29 23:18 ` [PATCH 07/10] [elf][non-regset] uninline elf_core_copy_task_fpregs() (and lose pt_regs argument) Al Viro
2022-11-08 9:41 ` Geert Uytterhoeven
2022-10-29 23:18 ` [PATCH 08/10] [elf][non-regset] use elf_core_copy_task_regs() for dumper as well Al Viro
2022-10-29 23:18 ` [PATCH 09/10] [elf] unify regset and non-regset cases Al Viro
2022-10-29 23:18 ` [PATCH 10/10] [elf] get rid of get_note_info_size() Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221029231850.3668437-4-viro@zeniv.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®