* [PATCH] scsi: qla2xxx: Remove unused variable found_devs
@ 2022-11-01 10:47 Colin Ian King
2022-11-17 18:29 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-11-01 10:47 UTC (permalink / raw)
To: Nilesh Javali, GR-QLogic-Storage-Upstream,
James E . J . Bottomley, Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
Variable found_devs is just being incremented and it's never used
anywhere else. The variable and the increment are redundant so
remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/scsi/qla2xxx/qla_init.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index e12db95de688..8f737d80bce4 100644
--- a/drivers/scsi/qla2xxx/qla_init.c
+++ b/drivers/scsi/qla2xxx/qla_init.c
@@ -5546,7 +5546,6 @@ static int
qla2x00_configure_local_loop(scsi_qla_host_t *vha)
{
int rval, rval2;
- int found_devs;
int found;
fc_port_t *fcport, *new_fcport;
uint16_t index;
@@ -5561,7 +5560,6 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
if (N2N_TOPO(ha))
return qla2x00_configure_n2n_loop(vha);
- found_devs = 0;
new_fcport = NULL;
entries = MAX_FIBRE_DEVICES_LOOP;
@@ -5720,8 +5718,6 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
/* Base iIDMA settings on HBA port speed. */
fcport->fp_speed = ha->link_data_rate;
-
- found_devs++;
}
list_for_each_entry(fcport, &vha->vp_fcports, list) {
--
2.37.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Remove unused variable found_devs
2022-11-01 10:47 [PATCH] scsi: qla2xxx: Remove unused variable found_devs Colin Ian King
@ 2022-11-17 18:29 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-11-17 18:29 UTC (permalink / raw)
To: James E . J . Bottomley, Colin Ian King, linux-scsi,
Nilesh Javali, GR-QLogic-Storage-Upstream
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Tue, 1 Nov 2022 10:47:33 +0000, Colin Ian King wrote:
> Variable found_devs is just being incremented and it's never used
> anywhere else. The variable and the increment are redundant so
> remove it.
>
>
Applied to 6.2/scsi-queue, thanks!
[1/1] scsi: qla2xxx: Remove unused variable found_devs
https://git.kernel.org/mkp/scsi/c/e137b81d30e7
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-17 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 10:47 [PATCH] scsi: qla2xxx: Remove unused variable found_devs Colin Ian King
2022-11-17 18:29 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®