mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment
@ 2022-11-01 16:29 Jonathan Neuschäfer
  2022-11-06 22:48 ` Pratyush Yadav
  2022-11-21 13:54 ` Tudor Ambarus
  0 siblings, 2 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2022-11-01 16:29 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-mtd, Jonathan Neuschäfer, Tudor Ambarus,
	Pratyush Yadav, Michael Walle, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra

It doesn't make sense to put "set" on its own line like that.

Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 drivers/mtd/spi-nor/sfdp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
index 2257f1b4c2e2d..3e0bb383ab8e2 100644
--- a/drivers/mtd/spi-nor/sfdp.c
+++ b/drivers/mtd/spi-nor/sfdp.c
@@ -135,8 +135,7 @@ struct sfdp_4bait {
 /**
  * spi_nor_read_raw() - raw read of serial flash memory. read_opcode,
  *			addr_nbytes and read_dummy members of the struct spi_nor
- *			should be previously
- * set.
+ *			should be previously set.
  * @nor:	pointer to a 'struct spi_nor'
  * @addr:	offset in the serial flash memory
  * @len:	number of bytes to read
--
2.35.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment
  2022-11-01 16:29 [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment Jonathan Neuschäfer
@ 2022-11-06 22:48 ` Pratyush Yadav
  2022-11-21 13:54 ` Tudor Ambarus
  1 sibling, 0 replies; 3+ messages in thread
From: Pratyush Yadav @ 2022-11-06 22:48 UTC (permalink / raw)
  To: Jonathan Neuschäfer
  Cc: linux-kernel, linux-mtd, Tudor Ambarus, Michael Walle,
	Miquel Raynal, Richard Weinberger, Vignesh Raghavendra

On 01/11/22 05:29PM, Jonathan Neuschäfer wrote:
> It doesn't make sense to put "set" on its own line like that.
> 
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

Acked-by: Pratyush Yadav <pratyush@kernel.org>

> ---
>  drivers/mtd/spi-nor/sfdp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/sfdp.c b/drivers/mtd/spi-nor/sfdp.c
> index 2257f1b4c2e2d..3e0bb383ab8e2 100644
> --- a/drivers/mtd/spi-nor/sfdp.c
> +++ b/drivers/mtd/spi-nor/sfdp.c
> @@ -135,8 +135,7 @@ struct sfdp_4bait {
>  /**
>   * spi_nor_read_raw() - raw read of serial flash memory. read_opcode,
>   *			addr_nbytes and read_dummy members of the struct spi_nor
> - *			should be previously
> - * set.
> + *			should be previously set.
>   * @nor:	pointer to a 'struct spi_nor'
>   * @addr:	offset in the serial flash memory
>   * @len:	number of bytes to read
> --
> 2.35.1
> 

-- 
Regards,
Pratyush Yadav

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment
  2022-11-01 16:29 [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment Jonathan Neuschäfer
  2022-11-06 22:48 ` Pratyush Yadav
@ 2022-11-21 13:54 ` Tudor Ambarus
  1 sibling, 0 replies; 3+ messages in thread
From: Tudor Ambarus @ 2022-11-21 13:54 UTC (permalink / raw)
  To: j.neuschaefer, linux-kernel
  Cc: Tudor Ambarus, linux-mtd, vigneshr, pratyush, richard,
	miquel.raynal, michael

On Tue, 1 Nov 2022 17:29:06 +0100, Jonathan Neuschäfer wrote:
> It doesn't make sense to put "set" on its own line like that.
> 
> 

Applied to spi-nor/next, thanks!

[1/1] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment
      https://git.kernel.org/mtd/c/270450a1b6d8

Best regards,
-- 
Tudor Ambarus <tudor.ambarus@microchip.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-11-21 13:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 16:29 [PATCH] mtd: spi-nor: Fix formatting in spi_nor_read_raw() kerneldoc comment Jonathan Neuschäfer
2022-11-06 22:48 ` Pratyush Yadav
2022-11-21 13:54 ` Tudor Ambarus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®