* [PATCH] sunrpc: svc: Remove an unused static function svc_ungetu32()
@ 2022-11-04 1:43 Li zeming
2022-11-04 13:44 ` Chuck Lever III
0 siblings, 1 reply; 2+ messages in thread
From: Li zeming @ 2022-11-04 1:43 UTC (permalink / raw)
To: trond.myklebust, anna, chuck.lever, jlayton
Cc: linux-nfs, linux-kernel, Li zeming
The svc_ungetu32 function is not used, you could remove it.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
include/linux/sunrpc/svc.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index daecb009c05b..6990867470ca 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -220,13 +220,6 @@ static inline __be32 svc_getu32(struct kvec *iov)
return val;
}
-static inline void svc_ungetu32(struct kvec *iov)
-{
- __be32 *vp = (__be32 *)iov->iov_base;
- iov->iov_base = (void *)(vp - 1);
- iov->iov_len += sizeof(*vp);
-}
-
static inline void svc_putu32(struct kvec *iov, __be32 val)
{
__be32 *vp = iov->iov_base + iov->iov_len;
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] sunrpc: svc: Remove an unused static function svc_ungetu32()
2022-11-04 1:43 [PATCH] sunrpc: svc: Remove an unused static function svc_ungetu32() Li zeming
@ 2022-11-04 13:44 ` Chuck Lever III
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever III @ 2022-11-04 13:44 UTC (permalink / raw)
To: Li zeming
Cc: Trond Myklebust, Anna Schumaker, Jeff Layton,
Linux NFS Mailing List, linux-kernel
> On Nov 3, 2022, at 9:43 PM, Li zeming <zeming@nfschina.com> wrote:
>
> The svc_ungetu32 function is not used, you could remove it.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
Applied to nfsd's for-next. Thanks!
> ---
> include/linux/sunrpc/svc.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..6990867470ca 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -220,13 +220,6 @@ static inline __be32 svc_getu32(struct kvec *iov)
> return val;
> }
>
> -static inline void svc_ungetu32(struct kvec *iov)
> -{
> - __be32 *vp = (__be32 *)iov->iov_base;
> - iov->iov_base = (void *)(vp - 1);
> - iov->iov_len += sizeof(*vp);
> -}
> -
> static inline void svc_putu32(struct kvec *iov, __be32 val)
> {
> __be32 *vp = iov->iov_base + iov->iov_len;
> --
> 2.18.2
>
--
Chuck Lever
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-04 13:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-04 1:43 [PATCH] sunrpc: svc: Remove an unused static function svc_ungetu32() Li zeming
2022-11-04 13:44 ` Chuck Lever III
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®