* [PATCH] selftests/bpf: Fix unsigned expression compared with zero
@ 2022-11-05 10:17 Kang Minchul
2022-11-05 10:21 ` Kang Minchul
0 siblings, 1 reply; 2+ messages in thread
From: Kang Minchul @ 2022-11-05 10:17 UTC (permalink / raw)
To: Björn Töpel, Maciej Fijalkowski, Jonathan Lemon
Cc: Martin KaFai Lau, Song Liu, Yonghong Song, netdev, linux-kernel,
Kang Minchul
Variable ret is compared with zero even though it have set as u32.
So u32 to int conversion is needed.
Signed-off-by: Kang Minchul <tegongkang@gmail.com>
---
tools/testing/selftests/bpf/xskxceiver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
index 681a5db80dae..162d3a516f2c 100644
--- a/tools/testing/selftests/bpf/xskxceiver.c
+++ b/tools/testing/selftests/bpf/xskxceiver.c
@@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32 *pkt_nb, struct pollfd *fd
{
struct xsk_socket_info *xsk = ifobject->xsk;
bool use_poll = ifobject->use_poll;
- u32 i, idx = 0, ret, valid_pkts = 0;
+ u32 i, idx = 0, valid_pkts = 0;
+ int ret;
while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) {
if (use_poll) {
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] selftests/bpf: Fix unsigned expression compared with zero
2022-11-05 10:17 [PATCH] selftests/bpf: Fix unsigned expression compared with zero Kang Minchul
@ 2022-11-05 10:21 ` Kang Minchul
0 siblings, 0 replies; 2+ messages in thread
From: Kang Minchul @ 2022-11-05 10:21 UTC (permalink / raw)
To: Björn Töpel, Maciej Fijalkowski, Jonathan Lemon
Cc: Martin KaFai Lau, Song Liu, Yonghong Song, netdev, linux-kernel
2022년 11월 5일 (토) 오후 7:18, Kang Minchul <tegongkang@gmail.com>님이 작성:
>
> Variable ret is compared with zero even though it have set as u32.
> So u32 to int conversion is needed.
>
> Signed-off-by: Kang Minchul <tegongkang@gmail.com>
> ---
> tools/testing/selftests/bpf/xskxceiver.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/xskxceiver.c b/tools/testing/selftests/bpf/xskxceiver.c
> index 681a5db80dae..162d3a516f2c 100644
> --- a/tools/testing/selftests/bpf/xskxceiver.c
> +++ b/tools/testing/selftests/bpf/xskxceiver.c
> @@ -1006,7 +1006,8 @@ static int __send_pkts(struct ifobject *ifobject, u32 *pkt_nb, struct pollfd *fd
> {
> struct xsk_socket_info *xsk = ifobject->xsk;
> bool use_poll = ifobject->use_poll;
> - u32 i, idx = 0, ret, valid_pkts = 0;
> + u32 i, idx = 0, valid_pkts = 0;
> + int ret;
>
> while (xsk_ring_prod__reserve(&xsk->tx, BATCH_SIZE, &idx) < BATCH_SIZE) {
> if (use_poll) {
> --
> 2.34.1
>
I just found a grammatical error in the commit message.
I'll resend this with the correct message.
Sorry for the inconvenience.
Regards,
Kang Minchul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-05 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-05 10:17 [PATCH] selftests/bpf: Fix unsigned expression compared with zero Kang Minchul
2022-11-05 10:21 ` Kang Minchul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®