mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Mauro Lima <mauro.lima@eclypsium.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Mark Brown <broonie@kernel.org>, Sasha Levin <sashal@kernel.org>,
	tudor.ambarus@microchip.com, pratyush@kernel.org,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	andriy.shevchenko@linux.intel.com, lee.jones@linaro.org,
	linux-mtd@lists.infradead.org
Subject: [PATCH AUTOSEL 5.15 07/18] spi: intel: Fix the offset to get the 64K erase opcode
Date: Sun,  6 Nov 2022 12:04:56 -0500	[thread overview]
Message-ID: <20221106170509.1580304-7-sashal@kernel.org> (raw)
In-Reply-To: <20221106170509.1580304-1-sashal@kernel.org>

From: Mauro Lima <mauro.lima@eclypsium.com>

[ Upstream commit 6a43cd02ddbc597dc9a1f82c1e433f871a2f6f06 ]

According to documentation, the 64K erase opcode is located in VSCC
range [16:23] instead of [8:15].
Use the proper value to shift the mask over the correct range.

Signed-off-by: Mauro Lima <mauro.lima@eclypsium.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://lore.kernel.org/r/20221012152135.28353-1-mauro.lima@eclypsium.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/mtd/spi-nor/controllers/intel-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/controllers/intel-spi.c b/drivers/mtd/spi-nor/controllers/intel-spi.c
index a413892ff449..72dab5937df1 100644
--- a/drivers/mtd/spi-nor/controllers/intel-spi.c
+++ b/drivers/mtd/spi-nor/controllers/intel-spi.c
@@ -116,7 +116,7 @@
 #define ERASE_OPCODE_SHIFT		8
 #define ERASE_OPCODE_MASK		(0xff << ERASE_OPCODE_SHIFT)
 #define ERASE_64K_OPCODE_SHIFT		16
-#define ERASE_64K_OPCODE_MASK		(0xff << ERASE_OPCODE_SHIFT)
+#define ERASE_64K_OPCODE_MASK		(0xff << ERASE_64K_OPCODE_SHIFT)
 
 #define INTEL_SPI_TIMEOUT		5000 /* ms */
 #define INTEL_SPI_FIFO_SZ		64
-- 
2.35.1


  parent reply	other threads:[~2022-11-06 17:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-06 17:04 [PATCH AUTOSEL 5.15 01/18] ASoC: wm5102: Revert "ASoC: wm5102: Fix PM disable depth imbalance in wm5102_probe" Sasha Levin
2022-11-06 17:04 ` [PATCH AUTOSEL 5.15 02/18] ASoC: wm5110: Revert "ASoC: wm5110: Fix PM disable depth imbalance in wm5110_probe" Sasha Levin
2022-11-06 17:04 ` [PATCH AUTOSEL 5.15 03/18] ASoC: wm8997: Revert "ASoC: wm8997: Fix PM disable depth imbalance in wm8997_probe" Sasha Levin
2022-11-06 17:04 ` [PATCH AUTOSEL 5.15 04/18] ASoC: mt6660: Keep the pm_runtime enables before component stuff in mt6660_i2c_probe Sasha Levin
2022-11-06 17:04 ` [PATCH AUTOSEL 5.15 05/18] ASoC: rt1019: Fix the TDM settings Sasha Levin
2022-11-06 17:04 ` [PATCH AUTOSEL 5.15 06/18] ASoC: wm8962: Add an event handler for TEMP_HP and TEMP_SPK Sasha Levin
2022-11-06 17:04 ` Sasha Levin [this message]
2022-11-06 17:04 ` [PATCH AUTOSEL 5.15 08/18] ASoC: codecs: jz4725b: add missed Line In power control bit Sasha Levin
2022-11-06 17:04 ` [PATCH AUTOSEL 5.15 09/18] ASoC: codecs: jz4725b: fix reported volume for Master ctl Sasha Levin
2022-11-06 17:04 ` [PATCH AUTOSEL 5.15 10/18] ASoC: codecs: jz4725b: use right control for Capture Volume Sasha Levin
2022-11-06 17:05 ` [PATCH AUTOSEL 5.15 11/18] ASoC: codecs: jz4725b: fix capture selector naming Sasha Levin
2022-11-06 17:05 ` [PATCH AUTOSEL 5.15 12/18] ASoC: Intel: sof_sdw: add quirk variant for LAPBC710 NUC15 Sasha Levin
2022-11-06 17:05 ` [PATCH AUTOSEL 5.15 13/18] selftests/futex: fix build for clang Sasha Levin
2022-11-06 17:05 ` [PATCH AUTOSEL 5.15 14/18] selftests/intel_pstate: fix build for ARCH=x86_64 Sasha Levin
2022-11-06 17:05 ` [PATCH AUTOSEL 5.15 15/18] rtc: cmos: fix build on non-ACPI platforms Sasha Levin
2022-11-06 17:05 ` [PATCH AUTOSEL 5.15 16/18] ASoC: rt1308-sdw: add the default value of some registers Sasha Levin
2022-11-06 17:05 ` [PATCH AUTOSEL 5.15 17/18] drm/amd/display: Remove wrong pipe control lock Sasha Levin
2022-11-06 17:05 ` [PATCH AUTOSEL 5.15 18/18] ACPI: scan: Add LATT2021 to acpi_ignore_dep_ids[] Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221106170509.1580304-7-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mauro.lima@eclypsium.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®