* [PATCH] ext2: Fix some kernel-doc warnings
@ 2022-11-11 6:43 Bo Liu
2022-11-11 6:46 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Bo Liu @ 2022-11-11 6:43 UTC (permalink / raw)
To: jack; +Cc: linux-ext4, linux-kernel, Bo Liu
The current code provokes some kernel-doc warnings:
fs/ext2/dir.c:417: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Signed-off-by: Bo Liu <liubo03@inspur.com>
---
fs/ext2/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c
index 8f597753ac12..27873733ed8c 100644
--- a/fs/ext2/dir.c
+++ b/fs/ext2/dir.c
@@ -413,7 +413,7 @@ struct ext2_dir_entry_2 *ext2_find_entry (struct inode *dir,
return de;
}
-/**
+/*
* Return the '..' directory entry and the page in which the entry was found
* (as a parameter - p).
*
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext2: Fix some kernel-doc warnings
2022-11-11 6:43 [PATCH] ext2: Fix some kernel-doc warnings Bo Liu
@ 2022-11-11 6:46 ` Randy Dunlap
2022-11-11 14:36 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2022-11-11 6:46 UTC (permalink / raw)
To: Bo Liu, jack; +Cc: linux-ext4, linux-kernel
On 11/10/22 22:43, Bo Liu wrote:
> The current code provokes some kernel-doc warnings:
> fs/ext2/dir.c:417: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>
> Signed-off-by: Bo Liu <liubo03@inspur.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> fs/ext2/dir.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c
> index 8f597753ac12..27873733ed8c 100644
> --- a/fs/ext2/dir.c
> +++ b/fs/ext2/dir.c
> @@ -413,7 +413,7 @@ struct ext2_dir_entry_2 *ext2_find_entry (struct inode *dir,
> return de;
> }
>
> -/**
> +/*
> * Return the '..' directory entry and the page in which the entry was found
> * (as a parameter - p).
> *
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ext2: Fix some kernel-doc warnings
2022-11-11 6:46 ` Randy Dunlap
@ 2022-11-11 14:36 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2022-11-11 14:36 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Bo Liu, jack, linux-ext4, linux-kernel
On Thu 10-11-22 22:46:46, Randy Dunlap wrote:
>
>
> On 11/10/22 22:43, Bo Liu wrote:
> > The current code provokes some kernel-doc warnings:
> > fs/ext2/dir.c:417: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> >
> > Signed-off-by: Bo Liu <liubo03@inspur.com>
>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks for the patch and review. I've added it to my tree.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-11 14:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 6:43 [PATCH] ext2: Fix some kernel-doc warnings Bo Liu
2022-11-11 6:46 ` Randy Dunlap
2022-11-11 14:36 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®