* [PATCH] xen/platform-pci: use define instead of literal number
@ 2022-11-14 14:23 Juergen Gross
2022-11-14 21:46 ` Stefano Stabellini
0 siblings, 1 reply; 2+ messages in thread
From: Juergen Gross @ 2022-11-14 14:23 UTC (permalink / raw)
To: linux-kernel
Cc: Juergen Gross, Stefano Stabellini, Oleksandr Tyshchenko, xen-devel
Instead of "0x01" use the HVM_PARAM_CALLBACK_TYPE_PCI_INTX define from
the interface header in get_callback_via().
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/xen/platform-pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
index 18f0ed8b1f93..24a3de1b7b03 100644
--- a/drivers/xen/platform-pci.c
+++ b/drivers/xen/platform-pci.c
@@ -54,7 +54,8 @@ static uint64_t get_callback_via(struct pci_dev *pdev)
pin = pdev->pin;
/* We don't know the GSI. Specify the PCI INTx line instead. */
- return ((uint64_t)0x01 << HVM_CALLBACK_VIA_TYPE_SHIFT) | /* PCI INTx identifier */
+ return ((uint64_t)HVM_PARAM_CALLBACK_TYPE_PCI_INTX <<
+ HVM_CALLBACK_VIA_TYPE_SHIFT) |
((uint64_t)pci_domain_nr(pdev->bus) << 32) |
((uint64_t)pdev->bus->number << 16) |
((uint64_t)(pdev->devfn & 0xff) << 8) |
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/platform-pci: use define instead of literal number
2022-11-14 14:23 [PATCH] xen/platform-pci: use define instead of literal number Juergen Gross
@ 2022-11-14 21:46 ` Stefano Stabellini
0 siblings, 0 replies; 2+ messages in thread
From: Stefano Stabellini @ 2022-11-14 21:46 UTC (permalink / raw)
To: Juergen Gross
Cc: linux-kernel, Stefano Stabellini, Oleksandr Tyshchenko, xen-devel
On Mon, 14 Nov 2022, Juergen Gross wrote:
> Instead of "0x01" use the HVM_PARAM_CALLBACK_TYPE_PCI_INTX define from
> the interface header in get_callback_via().
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> drivers/xen/platform-pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/xen/platform-pci.c b/drivers/xen/platform-pci.c
> index 18f0ed8b1f93..24a3de1b7b03 100644
> --- a/drivers/xen/platform-pci.c
> +++ b/drivers/xen/platform-pci.c
> @@ -54,7 +54,8 @@ static uint64_t get_callback_via(struct pci_dev *pdev)
> pin = pdev->pin;
>
> /* We don't know the GSI. Specify the PCI INTx line instead. */
> - return ((uint64_t)0x01 << HVM_CALLBACK_VIA_TYPE_SHIFT) | /* PCI INTx identifier */
> + return ((uint64_t)HVM_PARAM_CALLBACK_TYPE_PCI_INTX <<
> + HVM_CALLBACK_VIA_TYPE_SHIFT) |
> ((uint64_t)pci_domain_nr(pdev->bus) << 32) |
> ((uint64_t)pdev->bus->number << 16) |
> ((uint64_t)(pdev->devfn & 0xff) << 8) |
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-14 21:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-14 14:23 [PATCH] xen/platform-pci: use define instead of literal number Juergen Gross
2022-11-14 21:46 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®