mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ACPI: Enable FPDT on arm64
@ 2022-11-09 17:47 Jeremy Linton
  2022-11-14 16:12 ` Sudeep Holla
  2022-11-14 19:34 ` Will Deacon
  0 siblings, 2 replies; 5+ messages in thread
From: Jeremy Linton @ 2022-11-09 17:47 UTC (permalink / raw)
  To: linux-acpi
  Cc: catalin.marinas, will, corbet, rafael, lenb, linux-arm-kernel,
	linux-doc, linux-kernel, Jeremy Linton

FPDT provides some boot timing records useful for analyzing
parts of the UEFI boot stack. Given the existing code works
on arm64, and allows reading the values without utilizing
/dev/mem it seems like a good idea to turn it on.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Documentation/arm64/acpi_object_usage.rst | 2 +-
 drivers/acpi/Kconfig                      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/arm64/acpi_object_usage.rst b/Documentation/arm64/acpi_object_usage.rst
index 0609da73970b..484ef9676653 100644
--- a/Documentation/arm64/acpi_object_usage.rst
+++ b/Documentation/arm64/acpi_object_usage.rst
@@ -163,7 +163,7 @@ FPDT   Section 5.2.23 (signature == "FPDT")
 
        **Firmware Performance Data Table**
 
-       Optional, not currently supported.
+       Optional, useful for boot performance profiling.
 
 GTDT   Section 5.2.24 (signature == "GTDT")
 
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 473241b5193f..1cc11d2a2a88 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -90,7 +90,7 @@ config ACPI_SPCR_TABLE
 
 config ACPI_FPDT
 	bool "ACPI Firmware Performance Data Table (FPDT) support"
-	depends on X86_64
+	depends on X86_64 || ARM64
 	help
 	  Enable support for the Firmware Performance Data Table (FPDT).
 	  This table provides information on the timing of the system
-- 
2.38.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ACPI: Enable FPDT on arm64
  2022-11-09 17:47 [PATCH] ACPI: Enable FPDT on arm64 Jeremy Linton
@ 2022-11-14 16:12 ` Sudeep Holla
  2022-11-14 16:16   ` Rafael J. Wysocki
  2022-11-14 19:34 ` Will Deacon
  1 sibling, 1 reply; 5+ messages in thread
From: Sudeep Holla @ 2022-11-14 16:12 UTC (permalink / raw)
  To: Jeremy Linton, rafael
  Cc: linux-acpi, catalin.marinas, will, corbet, lenb,
	linux-arm-kernel, linux-doc, linux-kernel

On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> FPDT provides some boot timing records useful for analyzing
> parts of the UEFI boot stack. Given the existing code works
> on arm64, and allows reading the values without utilizing
> /dev/mem it seems like a good idea to turn it on.
>

FWIW, this looks good to me.

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

Hi Rafael,

Just saw this marked as "Handled Elsewhere", do you prefer to be merged
via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
and doc changes. Let us know.

-- 
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ACPI: Enable FPDT on arm64
  2022-11-14 16:12 ` Sudeep Holla
@ 2022-11-14 16:16   ` Rafael J. Wysocki
  2022-11-14 18:00     ` Will Deacon
  0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2022-11-14 16:16 UTC (permalink / raw)
  To: Sudeep Holla
  Cc: Jeremy Linton, rafael, linux-acpi, catalin.marinas, will, corbet,
	lenb, linux-arm-kernel, linux-doc, linux-kernel

On Mon, Nov 14, 2022 at 5:12 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> > FPDT provides some boot timing records useful for analyzing
> > parts of the UEFI boot stack. Given the existing code works
> > on arm64, and allows reading the values without utilizing
> > /dev/mem it seems like a good idea to turn it on.
> >
>
> FWIW, this looks good to me.
>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Hi Rafael,
>
> Just saw this marked as "Handled Elsewhere", do you prefer to be merged
> via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
> and doc changes. Let us know.

There is arm64 in the subject, though, so I think it belongs there.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ACPI: Enable FPDT on arm64
  2022-11-14 16:16   ` Rafael J. Wysocki
@ 2022-11-14 18:00     ` Will Deacon
  0 siblings, 0 replies; 5+ messages in thread
From: Will Deacon @ 2022-11-14 18:00 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Sudeep Holla, Jeremy Linton, linux-acpi, catalin.marinas, corbet,
	lenb, linux-arm-kernel, linux-doc, linux-kernel

On Mon, Nov 14, 2022 at 05:16:59PM +0100, Rafael J. Wysocki wrote:
> On Mon, Nov 14, 2022 at 5:12 PM Sudeep Holla <sudeep.holla@arm.com> wrote:
> >
> > On Wed, Nov 09, 2022 at 11:47:20AM -0600, Jeremy Linton wrote:
> > > FPDT provides some boot timing records useful for analyzing
> > > parts of the UEFI boot stack. Given the existing code works
> > > on arm64, and allows reading the values without utilizing
> > > /dev/mem it seems like a good idea to turn it on.
> > >
> >
> > FWIW, this looks good to me.
> >
> > Acked-by: Sudeep Holla <sudeep.holla@arm.com>
> >
> > Hi Rafael,
> >
> > Just saw this marked as "Handled Elsewhere", do you prefer to be merged
> > via arm64 or other tree ? This doesn't have any arm64 changes, just Kconfig
> > and doc changes. Let us know.
> 
> There is arm64 in the subject, though, so I think it belongs there.

Okey doke, I'll grab 'em.

Cheers!

Will

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ACPI: Enable FPDT on arm64
  2022-11-09 17:47 [PATCH] ACPI: Enable FPDT on arm64 Jeremy Linton
  2022-11-14 16:12 ` Sudeep Holla
@ 2022-11-14 19:34 ` Will Deacon
  1 sibling, 0 replies; 5+ messages in thread
From: Will Deacon @ 2022-11-14 19:34 UTC (permalink / raw)
  To: Jeremy Linton, linux-acpi
  Cc: catalin.marinas, kernel-team, Will Deacon, linux-kernel, lenb,
	linux-doc, rafael, corbet, linux-arm-kernel

On Wed, 9 Nov 2022 11:47:20 -0600, Jeremy Linton wrote:
> FPDT provides some boot timing records useful for analyzing
> parts of the UEFI boot stack. Given the existing code works
> on arm64, and allows reading the values without utilizing
> /dev/mem it seems like a good idea to turn it on.
> 
> 

Applied to arm64 (for-next/acpi), thanks!

[1/1] ACPI: Enable FPDT on arm64
      https://git.kernel.org/arm64/c/c2465f95c4e7

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-11-14 19:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-09 17:47 [PATCH] ACPI: Enable FPDT on arm64 Jeremy Linton
2022-11-14 16:12 ` Sudeep Holla
2022-11-14 16:16   ` Rafael J. Wysocki
2022-11-14 18:00     ` Will Deacon
2022-11-14 19:34 ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®