* [PATCH] drm/msm: Enable clamp_to_idle for 7c3
@ 2022-11-15 15:55 Rob Clark
2022-11-15 16:01 ` Doug Anderson
0 siblings, 1 reply; 3+ messages in thread
From: Rob Clark @ 2022-11-15 15:55 UTC (permalink / raw)
To: dri-devel
Cc: freedreno, linux-arm-msm, Akhil P Oommen, Rob Clark, Rob Clark,
Abhinav Kumar, Dmitry Baryshkov, Sean Paul, David Airlie,
Daniel Vetter, Chia-I Wu, Konrad Dybcio, Douglas Anderson,
open list
From: Rob Clark <robdclark@chromium.org>
This was overlooked.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index ebe9599a8316..e495d8e192db 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -2029,13 +2029,6 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
adreno_cmp_rev(ADRENO_REV(6, 3, 5, ANY_ID), info->rev)))
adreno_gpu->base.hw_apriv = true;
- /*
- * For now only clamp to idle freq for devices where this is known not
- * to cause power supply issues:
- */
- if (info && (info->revn == 618))
- gpu->clamp_to_idle = true;
-
a6xx_llc_slices_init(pdev, a6xx_gpu);
ret = a6xx_set_supported_hw(&pdev->dev, config->rev);
@@ -2050,6 +2043,13 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
return ERR_PTR(ret);
}
+ /*
+ * For now only clamp to idle freq for devices where this is known not
+ * to cause power supply issues:
+ */
+ if (adreno_is_a618(adreno_gpu) || adreno_is_7c3(adreno_gpu))
+ gpu->clamp_to_idle = true;
+
/* Check if there is a GMU phandle and set it up */
node = of_parse_phandle(pdev->dev.of_node, "qcom,gmu", 0);
--
2.38.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: Enable clamp_to_idle for 7c3
2022-11-15 15:55 [PATCH] drm/msm: Enable clamp_to_idle for 7c3 Rob Clark
@ 2022-11-15 16:01 ` Doug Anderson
2022-11-15 18:22 ` Chia-I Wu
0 siblings, 1 reply; 3+ messages in thread
From: Doug Anderson @ 2022-11-15 16:01 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, freedreno, linux-arm-msm, Akhil P Oommen, Rob Clark,
Abhinav Kumar, Dmitry Baryshkov, Sean Paul, David Airlie,
Daniel Vetter, Chia-I Wu, Konrad Dybcio, open list
Hi,
On Tue, Nov 15, 2022 at 7:55 AM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> This was overlooked.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: Enable clamp_to_idle for 7c3
2022-11-15 16:01 ` Doug Anderson
@ 2022-11-15 18:22 ` Chia-I Wu
0 siblings, 0 replies; 3+ messages in thread
From: Chia-I Wu @ 2022-11-15 18:22 UTC (permalink / raw)
To: Doug Anderson
Cc: Rob Clark, dri-devel, freedreno, linux-arm-msm, Akhil P Oommen,
Rob Clark, Abhinav Kumar, Dmitry Baryshkov, Sean Paul,
David Airlie, Daniel Vetter, Konrad Dybcio, open list
On Tue, Nov 15, 2022 at 8:01 AM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Tue, Nov 15, 2022 at 7:55 AM Rob Clark <robdclark@gmail.com> wrote:
> >
> > From: Rob Clark <robdclark@chromium.org>
> >
> > This was overlooked.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-15 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-15 15:55 [PATCH] drm/msm: Enable clamp_to_idle for 7c3 Rob Clark
2022-11-15 16:01 ` Doug Anderson
2022-11-15 18:22 ` Chia-I Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®