* [PATCH] dt-bindings: gpio: gpio-davinci: Increase maxItems in gpio-line-names
@ 2022-11-15 23:10 Nishanth Menon
2022-11-16 8:58 ` Krzysztof Kozlowski
2022-11-16 9:23 ` Bartosz Golaszewski
0 siblings, 2 replies; 3+ messages in thread
From: Nishanth Menon @ 2022-11-15 23:10 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Bartosz Golaszewski,
Linus Walleij, Keerthy
Cc: linux-kernel, devicetree, linux-gpio, Robert Nelson, Nishanth Menon
gpio-line-names really depends on ti,ngpios. However, the maximum value
we have seen across the board is on K2G and da850 platforms where it can
be upto 144.
Link: https://lore.kernel.org/linux-arm-kernel/20221115200357.qa2rvw3clbz7unzq@symptom/T/#u
Fixes: c830b87a761b ("dt-bindings: gpio: gpio-davinci: Convert to json-schema")
Reported-by: Robert Nelson <robertcnelson@gmail.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
I dont see a practical scheme to set the maxItems based on ti,ngpios,
but deleting the maxItems was softening the check as well.
Documentation/devicetree/bindings/gpio/gpio-davinci.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
index f32e09ef937c..10e56cf306db 100644
--- a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
+++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
@@ -35,7 +35,7 @@ properties:
gpio-line-names:
description: strings describing the names of each gpio line.
minItems: 1
- maxItems: 100
+ maxItems: 144
"#gpio-cells":
const: 2
--
2.31.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: gpio: gpio-davinci: Increase maxItems in gpio-line-names
2022-11-15 23:10 [PATCH] dt-bindings: gpio: gpio-davinci: Increase maxItems in gpio-line-names Nishanth Menon
@ 2022-11-16 8:58 ` Krzysztof Kozlowski
2022-11-16 9:23 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-16 8:58 UTC (permalink / raw)
To: Nishanth Menon, Krzysztof Kozlowski, Rob Herring,
Bartosz Golaszewski, Linus Walleij, Keerthy
Cc: linux-kernel, devicetree, linux-gpio, Robert Nelson
On 16/11/2022 00:10, Nishanth Menon wrote:
> gpio-line-names really depends on ti,ngpios. However, the maximum value
> we have seen across the board is on K2G and da850 platforms where it can
> be upto 144.
>
> Link: https://lore.kernel.org/linux-arm-kernel/20221115200357.qa2rvw3clbz7unzq@symptom/T/#u
> Fixes: c830b87a761b ("dt-bindings: gpio: gpio-davinci: Convert to json-schema")
> Reported-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: gpio: gpio-davinci: Increase maxItems in gpio-line-names
2022-11-15 23:10 [PATCH] dt-bindings: gpio: gpio-davinci: Increase maxItems in gpio-line-names Nishanth Menon
2022-11-16 8:58 ` Krzysztof Kozlowski
@ 2022-11-16 9:23 ` Bartosz Golaszewski
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2022-11-16 9:23 UTC (permalink / raw)
To: Nishanth Menon
Cc: Krzysztof Kozlowski, Rob Herring, Linus Walleij, Keerthy,
linux-kernel, devicetree, linux-gpio, Robert Nelson
On Wed, Nov 16, 2022 at 12:10 AM Nishanth Menon <nm@ti.com> wrote:
>
> gpio-line-names really depends on ti,ngpios. However, the maximum value
> we have seen across the board is on K2G and da850 platforms where it can
> be upto 144.
>
> Link: https://lore.kernel.org/linux-arm-kernel/20221115200357.qa2rvw3clbz7unzq@symptom/T/#u
> Fixes: c830b87a761b ("dt-bindings: gpio: gpio-davinci: Convert to json-schema")
> Reported-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> I dont see a practical scheme to set the maxItems based on ti,ngpios,
> but deleting the maxItems was softening the check as well.
>
> Documentation/devicetree/bindings/gpio/gpio-davinci.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> index f32e09ef937c..10e56cf306db 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.yaml
> @@ -35,7 +35,7 @@ properties:
> gpio-line-names:
> description: strings describing the names of each gpio line.
> minItems: 1
> - maxItems: 100
> + maxItems: 144
>
> "#gpio-cells":
> const: 2
> --
> 2.31.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-16 9:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-15 23:10 [PATCH] dt-bindings: gpio: gpio-davinci: Increase maxItems in gpio-line-names Nishanth Menon
2022-11-16 8:58 ` Krzysztof Kozlowski
2022-11-16 9:23 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®