* [PATCH] media: i2c: refer to config VIDEO_DEV to make ov08x40 image sensor driver usable
@ 2022-11-16 9:40 Lukas Bulwahn
2022-11-16 13:35 ` Kieran Bingham
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Bulwahn @ 2022-11-16 9:40 UTC (permalink / raw)
To: Shawn Tu, Jason Chen, Sakari Ailus, Mauro Carvalho Chehab, linux-media
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Commit 9958d30f38b9 ("media: Kconfig: cleanup VIDEO_DEV dependencies")
removes the config VIDEO_V4L2 as it is merged with config VIDEO_DEV.
Long after this change, commit 38fc5136ac16 ("media: i2c: Add ov08x40 image
sensor driver") introduces and refers to the removed config VIDEO_V4L2,
basically making this driver impossible to build, test and use due to
dependencies that cannot be met.
Refer to config VIDEO_DEV instead to make this driver usable.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/media/i2c/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 49c1c27afdc1..4a4ae9c20119 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -366,7 +366,7 @@ config VIDEO_OV08D10
config VIDEO_OV08X40
tristate "OmniVision OV08X40 sensor support"
- depends on VIDEO_V4L2 && I2C
+ depends on VIDEO_DEV && I2C
select MEDIA_CONTROLLER
select VIDEO_V4L2_SUBDEV_API
select V4L2_FWNODE
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: refer to config VIDEO_DEV to make ov08x40 image sensor driver usable
2022-11-16 9:40 [PATCH] media: i2c: refer to config VIDEO_DEV to make ov08x40 image sensor driver usable Lukas Bulwahn
@ 2022-11-16 13:35 ` Kieran Bingham
0 siblings, 0 replies; 2+ messages in thread
From: Kieran Bingham @ 2022-11-16 13:35 UTC (permalink / raw)
To: Jason Chen, Lukas Bulwahn, Mauro Carvalho Chehab, Sakari Ailus,
Shawn Tu, linux-media
Cc: kernel-janitors, linux-kernel, Lukas Bulwahn
Quoting Lukas Bulwahn (2022-11-16 09:40:06)
> Commit 9958d30f38b9 ("media: Kconfig: cleanup VIDEO_DEV dependencies")
> removes the config VIDEO_V4L2 as it is merged with config VIDEO_DEV.
>
> Long after this change, commit 38fc5136ac16 ("media: i2c: Add ov08x40 image
> sensor driver") introduces and refers to the removed config VIDEO_V4L2,
> basically making this driver impossible to build, test and use due to
> dependencies that cannot be met.
>
> Refer to config VIDEO_DEV instead to make this driver usable.
Fixes: 38fc5136ac16 ("media: i2c: Add ov08x40 image sensor driver")
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> drivers/media/i2c/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> index 49c1c27afdc1..4a4ae9c20119 100644
> --- a/drivers/media/i2c/Kconfig
> +++ b/drivers/media/i2c/Kconfig
> @@ -366,7 +366,7 @@ config VIDEO_OV08D10
>
> config VIDEO_OV08X40
> tristate "OmniVision OV08X40 sensor support"
> - depends on VIDEO_V4L2 && I2C
> + depends on VIDEO_DEV && I2C
> select MEDIA_CONTROLLER
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-16 13:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-16 9:40 [PATCH] media: i2c: refer to config VIDEO_DEV to make ov08x40 image sensor driver usable Lukas Bulwahn
2022-11-16 13:35 ` Kieran Bingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®