From: Steven Rostedt <rostedt@goodmis.org>
To: Wang Wensheng <wangwensheng4@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <mhiramat@kernel.org>,
<mark.rutland@arm.com>, <xuqiang36@huawei.com>,
<weiyongjun1@huawei.com>
Subject: Re: [PATCH -next 3/3] ftrace: Delete unused variable ftrace_update_time
Date: Thu, 17 Nov 2022 15:36:30 -0500 [thread overview]
Message-ID: <20221117153630.4af6a7da@gandalf.local.home> (raw)
In-Reply-To: <20221109094434.84046-4-wangwensheng4@huawei.com>
On Wed, 9 Nov 2022 09:44:34 +0000
Wang Wensheng <wangwensheng4@huawei.com> wrote:
> ftrace_update_time is not used anywhere else after initialization. So
> delete it together with its initial code.
Thanks for the first two patches. They are definitely fixes and I plan on
testing and adding them to my next pull request.
As for this one, this has been more of a reminder for me to one day (I
know, it's been years!) to export this to see from user space. I sometimes
do it manually with a printk(), but it should probably be always shown.
Perhaps in dyn_ftrace_total_info ?
-- Steve
prev parent reply other threads:[~2022-11-17 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 9:44 [PATCH -next 0/3] Optimize code for ftrace Wang Wensheng
2022-11-09 9:44 ` [PATCH -next 1/3] ftrace: Fix the possible incorrect kernel message Wang Wensheng
2022-11-09 9:44 ` [PATCH -next 2/3] ftrace: Optimize the allocation for mcount entries Wang Wensheng
2022-11-09 9:44 ` [PATCH -next 3/3] ftrace: Delete unused variable ftrace_update_time Wang Wensheng
2022-11-17 20:36 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221117153630.4af6a7da@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=wangwensheng4@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=xuqiang36@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®