[PATCH v3 1/1] pwm: core: Remove S_IFREG from debugfs_create_file()

[PATCH v3 1/1] pwm: core: Remove S_IFREG from debugfs_create_file()

[Andy Shevchenko]

The debugfs_create_file() already has a check and adds S_IFREG
automatically. Remove unneeded flag.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3: resent as a standalone patch (Uwe)
 drivers/pwm/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 855abd0a776f..8f5cb665940f 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -1179,8 +1179,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs);
 
 static int __init pwm_debugfs_init(void)
 {
-	debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL,
-			    &pwm_debugfs_fops);
+	debugfs_create_file("pwm", 0444, NULL, NULL, &pwm_debugfs_fops);
 
 	return 0;
 }
-- 
2.35.1

Re: [PATCH v3 1/1] pwm: core: Remove S_IFREG from debugfs_create_file()

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

Hello,

On Thu, Nov 17, 2022 at 06:58:12PM +0200, Andy Shevchenko wrote:
> The debugfs_create_file() already has a check and adds S_IFREG
> automatically. Remove unneeded flag.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3: resent as a standalone patch (Uwe)

My idea was that Thierry picks v2 from the initial series, my intention
wasn't to make you resend it alone. Anyhow:

Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]