* Missing generic netlink controller operations
@ 2022-11-17 3:54 Collin
2022-11-17 16:38 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Collin @ 2022-11-17 3:54 UTC (permalink / raw)
To: linux-kernel, linux-netdev
While messing around with libnl and netlink I noticed that despite existing in an enum in linux/genetlink.h, the CTRL_CMD_{NEW,DEL,GET}OPS operations (and in fact, all operations except for CTRL_CMD_{NEWFAMILY,DELFAMILY,NEWMCAST_GRP,DELMCAST_GRP}) are unimplemented, and have been around, untouched, since the introduction of the generic netlink family. Is there a reason these exist without implementation, or has it simply not been done?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Missing generic netlink controller operations
2022-11-17 3:54 Missing generic netlink controller operations Collin
@ 2022-11-17 16:38 ` Randy Dunlap
2022-11-18 4:45 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2022-11-17 16:38 UTC (permalink / raw)
To: Collin, linux-kernel, Network Development
[change linux-netdev@ to netdev@]
On 11/16/22 19:54, Collin wrote:
> While messing around with libnl and netlink I noticed that despite existing in an enum in linux/genetlink.h, the CTRL_CMD_{NEW,DEL,GET}OPS operations (and in fact, all operations except for CTRL_CMD_{NEWFAMILY,DELFAMILY,NEWMCAST_GRP,DELMCAST_GRP}) are unimplemented, and have been around, untouched, since the introduction of the generic netlink family. Is there a reason these exist without implementation, or has it simply not been done?
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Missing generic netlink controller operations
2022-11-17 16:38 ` Randy Dunlap
@ 2022-11-18 4:45 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-11-18 4:45 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Collin, linux-kernel, Network Development
On Thu, 17 Nov 2022 08:38:40 -0800 Randy Dunlap wrote:
> [change linux-netdev@ to netdev@]
>
> On 11/16/22 19:54, Collin wrote:
> > While messing around with libnl and netlink I noticed that despite
> > existing in an enum in linux/genetlink.h, the
> > CTRL_CMD_{NEW,DEL,GET}OPS operations (and in fact, all operations
> > except for
> > CTRL_CMD_{NEWFAMILY,DELFAMILY,NEWMCAST_GRP,DELMCAST_GRP}) are
> > unimplemented, and have been around, untouched, since the
> > introduction of the generic netlink family. Is there a reason these
> > exist without implementation, or has it simply not been done?
Only CTRL_CMD_GETMCAST_GRP was never used AFAIU, it was likely added
to maintain the triplet cadence (NEW,DEL,GET); probably cargo cult /
inspired by the classic netlink / rtnl.
Ops used to be more dynamic, and separately registered, I think.
Which found no real life use, so that option was dropped and now
all ops must be statically defined for the family at family
registration time.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-18 4:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17 3:54 Missing generic netlink controller operations Collin
2022-11-17 16:38 ` Randy Dunlap
2022-11-18 4:45 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®