From: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
To: Wang Yufen <wangyufen@huawei.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@somainline.org, sumit.semwal@linaro.org,
christian.koenig@amd.com, vkoul@kernel.org,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH] i2c: qcom-geni: fix error return code in geni_i2c_gpi_xfer
Date: Mon, 21 Nov 2022 12:57:54 +0100 [thread overview]
Message-ID: <20221121115754.GA39395@tom-ThinkPad-T14s-Gen-2i> (raw)
In-Reply-To: <1669025872-44226-1-git-send-email-wangyufen@huawei.com>
Hi Wang,
On Mon, Nov 21, 2022 at 06:17:52PM +0800, Wang Yufen wrote:
> Fix to return a negative error code from the gi2c->err instead of
> 0.
>
> Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index 84a7751..8fce98b 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -626,7 +626,6 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i
> dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n",
> gi2c->cur->flags, gi2c->cur->addr);
> gi2c->err = -ETIMEDOUT;
> - goto err;
Looks good to me.
Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasoluitons.com>
Regards,
Tommaso
> }
>
> if (gi2c->err) {
> --
> 1.8.3.1
>
--
Tommaso Merciai
Embedded Linux Engineer
tommaso.merciai@amarulasolutions.com
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@amarulasolutions.com
www.amarulasolutions.com
prev parent reply other threads:[~2022-11-21 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 10:17 Wang Yufen
2022-11-21 11:57 ` Tommaso Merciai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121115754.GA39395@tom-ThinkPad-T14s-Gen-2i \
--to=tommaso.merciai@amarulasolutions.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.dybcio@somainline.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=vkoul@kernel.org \
--cc=wangyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®