From: Steven Rostedt <rostedt@goodmis.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: linux-kernel@vger.kernel.org, mhiramat@kernel.org, revest@chromium.org
Subject: Re: [PATCH 2/3] ftrace: export ftrace_free_filter() to modules
Date: Tue, 22 Nov 2022 17:07:54 -0500 [thread overview]
Message-ID: <20221122170754.7962724c@gandalf.local.home> (raw)
In-Reply-To: <20221122165938.353ee7c0@gandalf.local.home>
On Tue, 22 Nov 2022 16:59:38 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> > + * This can allocate memory which must be freed before @ops can be freed,
> > + * either by remvoing eached filtered addr or by using
>
> I love how you cut and pasted two typos four times. ;-)
Besides the "remvoing" and "eached"...
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
But please send a v2.
-- Steve
next prev parent reply other threads:[~2022-11-22 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 17:09 [PATCH 0/3] ftrace: add sample code with dynamic ftrace_ops Mark Rutland
2022-11-03 17:09 ` [PATCH 1/3] ftrace: maintain samples/ftrace Mark Rutland
2022-11-03 17:09 ` [PATCH 2/3] ftrace: export ftrace_free_filter() to modules Mark Rutland
2022-11-22 21:59 ` Steven Rostedt
2022-11-22 22:07 ` Steven Rostedt [this message]
2023-01-03 11:34 ` Mark Rutland
2022-11-03 17:09 ` [PATCH 3/3] ftrace: add sample with custom ops Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221122170754.7962724c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=revest@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®