* [PATCH] crypto: x86/curve25519 - disable gcov
@ 2022-11-22 22:54 Joe Fradley
2022-12-02 10:20 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Joe Fradley @ 2022-11-22 22:54 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, x86, H. Peter Anvin
Cc: kernel-team, Joe Fradley, linux-crypto, linux-kernel
curve25519-x86_64.c fails to build when CONFIG_GCOV_KERNEL is enabled.
The error is "inline assembly requires more registers than available"
thrown from the `fsqr()` function. Therefore, excluding this file from
GCOV profiling until this issue is resolved. Thereby allowing
CONFIG_GCOV_PROFILE_ALL to be enabled for x86.
Signed-off-by: Joe Fradley <joefradley@google.com>
---
arch/x86/crypto/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/crypto/Makefile b/arch/x86/crypto/Makefile
index 3b1d701a4f6c..3e7a329235bd 100644
--- a/arch/x86/crypto/Makefile
+++ b/arch/x86/crypto/Makefile
@@ -107,3 +107,6 @@ quiet_cmd_perlasm = PERLASM $@
cmd_perlasm = $(PERL) $< > $@
$(obj)/%.S: $(src)/%.pl FORCE
$(call if_changed,perlasm)
+
+# Disable GCOV in odd or sensitive code
+GCOV_PROFILE_curve25519-x86_64.o := n
--
2.38.1.584.g0f3c55d4c2-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: x86/curve25519 - disable gcov
2022-11-22 22:54 [PATCH] crypto: x86/curve25519 - disable gcov Joe Fradley
@ 2022-12-02 10:20 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-12-02 10:20 UTC (permalink / raw)
To: Joe Fradley
Cc: David S. Miller, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, x86, H. Peter Anvin, kernel-team, linux-crypto,
linux-kernel
On Tue, Nov 22, 2022 at 02:54:49PM -0800, Joe Fradley wrote:
> curve25519-x86_64.c fails to build when CONFIG_GCOV_KERNEL is enabled.
> The error is "inline assembly requires more registers than available"
> thrown from the `fsqr()` function. Therefore, excluding this file from
> GCOV profiling until this issue is resolved. Thereby allowing
> CONFIG_GCOV_PROFILE_ALL to be enabled for x86.
>
> Signed-off-by: Joe Fradley <joefradley@google.com>
> ---
> arch/x86/crypto/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-02 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 22:54 [PATCH] crypto: x86/curve25519 - disable gcov Joe Fradley
2022-12-02 10:20 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®