From: shravan kumar <shravan.chippa@microchip.com>
To: <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
<mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Shravan Chippa" <shravan.chippa@microchip.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH v5 3/6] media: i2c: imx334: hblank set function modify
Date: Fri, 25 Nov 2022 10:38:04 +0530 [thread overview]
Message-ID: <20221125050807.1857479-4-shravan.chippa@microchip.com> (raw)
In-Reply-To: <20221125050807.1857479-1-shravan.chippa@microchip.com>
From: Shravan Chippa <shravan.chippa@microchip.com>
-If we one modes hblank will not change and it is readonly
-If we have multipull modes and if we do mode switch, hblank value will
change and __v4l2_ctrl_s_ctrl() returns error, so modified
function from __v4l2_ctrl_s_ctrl() to __v4l2_ctrl_modify_range()
will updated all values max, min default it is not showing any error
while changing the mode and update value
Suggested-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
---
drivers/media/i2c/imx334.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index acc9f9f15e47..d3bb62c162b3 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -382,7 +382,8 @@ static int imx334_update_controls(struct imx334 *imx334,
if (ret)
return ret;
- ret = __v4l2_ctrl_s_ctrl(imx334->hblank_ctrl, mode->hblank);
+ ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, IMX334_REG_MIN,
+ IMX334_REG_MAX, 1, mode->hblank);
if (ret)
return ret;
--
2.34.1
next prev parent reply other threads:[~2022-11-25 5:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 5:08 [PATCH v5 0/6] media: i2c: imx334: support lower bandwidth mode shravan kumar
2022-11-25 5:08 ` [PATCH v5 1/6] dt-bindings: imx334: modify link frequency in examples shravan kumar
2022-11-25 15:55 ` Sakari Ailus
2022-11-26 10:51 ` shravan kumar
2022-11-26 14:52 ` Sakari Ailus
2022-11-25 5:08 ` [PATCH v5 2/6] media: i2c: imx334: modify link frequency as for the configureation shravan kumar
2022-11-25 5:08 ` shravan kumar [this message]
2022-11-25 15:58 ` [PATCH v5 3/6] media: i2c: imx334: hblank set function modify Sakari Ailus
2022-11-25 5:08 ` [PATCH v5 4/6] media: i2c: imx334: add default values in 3840x2160@60 array shravan kumar
2022-11-25 16:02 ` Sakari Ailus
2022-11-26 10:58 ` shravan kumar
2022-11-25 5:08 ` [PATCH v5 5/6] media: i2c: imx334: support lower bandwidth mode shravan kumar
2022-11-25 16:15 ` Sakari Ailus
2022-11-25 5:08 ` [PATCH v5 6/6] media: i2c: imx334: updating pixel and link frequency shravan kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125050807.1857479-4-shravan.chippa@microchip.com \
--to=shravan.chippa@microchip.com \
--cc=daniele.alessandrelli@intel.com \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®