From: Dongliang Mu <dzm91@hust.edu.cn>
To: Martyn Welch <martyn@welchs.me.uk>,
Manohar Vanga <manohar.vanga@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dongliang Mu <dzm91@hust.edu.cn>, Arnd Bergmann <arnd@arndb.de>,
Mingyi Kang <jerrykang026@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: [PATCH 1/2] staging: vme_user: add list_del in the error handling of tsi148_dma_list_add
Date: Sat, 26 Nov 2022 20:56:33 +0800 [thread overview]
Message-ID: <20221126125642.16358-1-dzm91@hust.edu.cn> (raw)
Smatch reports the following issue:
drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add()
warn: '&entry->list' not removed from list
Fix this by adding list_del in the error handling code.
Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
---
drivers/staging/vme_user/vme_tsi148.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
index 020e0b3bce64..0171f46d1848 100644
--- a/drivers/staging/vme_user/vme_tsi148.c
+++ b/drivers/staging/vme_user/vme_tsi148.c
@@ -1751,6 +1751,7 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
return 0;
err_dma:
+ list_del(&entry->list);
err_dest:
err_source:
err_align:
--
2.37.1 (Apple Git-137.1)
next reply other threads:[~2022-11-26 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-26 12:56 Dongliang Mu [this message]
2022-11-26 12:56 ` [PATCH 2/2] staging: vme_user: fix coding style Dongliang Mu
2022-12-05 12:22 ` Greg Kroah-Hartman
2022-12-05 12:33 ` Dongliang Mu
2022-11-26 15:31 ` [PATCH 1/2] staging: vme_user: add list_del in the error handling of tsi148_dma_list_add Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221126125642.16358-1-dzm91@hust.edu.cn \
--to=dzm91@hust.edu.cn \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jerrykang026@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®