* [PATCH] hwmon: (hih6130) Modify mismatched function name
@ 2022-11-27 13:43 Jiapeng Chong
2022-11-27 15:01 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-11-27 13:43 UTC (permalink / raw)
To: jdelvare; +Cc: linux, linux-hwmon, linux-kernel, Jiapeng Chong, Abaci Robot
No functional modification involved.
drivers/hwmon/hih6130.c:185: warning: expecting prototype for hih6130_show_humidity(). Prototype was for hih6130_humidity_show() instead.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3264
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/hwmon/hih6130.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/hih6130.c b/drivers/hwmon/hih6130.c
index d9394e19fea8..764e6e185d98 100644
--- a/drivers/hwmon/hih6130.c
+++ b/drivers/hwmon/hih6130.c
@@ -172,7 +172,7 @@ static ssize_t hih6130_temperature_show(struct device *dev,
}
/**
- * hih6130_show_humidity() - show humidity measurement value in sysfs
+ * hih6130_humidity_show() - show humidity measurement value in sysfs
* @dev: device
* @attr: device attribute
* @buf: sysfs buffer (PAGE_SIZE) where measurement values are written to
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (hih6130) Modify mismatched function name
2022-11-27 13:43 [PATCH] hwmon: (hih6130) Modify mismatched function name Jiapeng Chong
@ 2022-11-27 15:01 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2022-11-27 15:01 UTC (permalink / raw)
To: Jiapeng Chong, jdelvare; +Cc: linux-hwmon, linux-kernel, Abaci Robot
On 11/27/22 05:43, Jiapeng Chong wrote:
> No functional modification involved.
>
> drivers/hwmon/hih6130.c:185: warning: expecting prototype for hih6130_show_humidity(). Prototype was for hih6130_humidity_show() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3264
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
NACK. We don't start changing function names because some robot
thinks we should. Please do not submit such patches against the hwmon
or watchdog subsystems.
Guenter
> ---
> drivers/hwmon/hih6130.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/hih6130.c b/drivers/hwmon/hih6130.c
> index d9394e19fea8..764e6e185d98 100644
> --- a/drivers/hwmon/hih6130.c
> +++ b/drivers/hwmon/hih6130.c
> @@ -172,7 +172,7 @@ static ssize_t hih6130_temperature_show(struct device *dev,
> }
>
> /**
> - * hih6130_show_humidity() - show humidity measurement value in sysfs
> + * hih6130_humidity_show() - show humidity measurement value in sysfs
> * @dev: device
> * @attr: device attribute
> * @buf: sysfs buffer (PAGE_SIZE) where measurement values are written to
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-27 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-27 13:43 [PATCH] hwmon: (hih6130) Modify mismatched function name Jiapeng Chong
2022-11-27 15:01 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®